Merge pull request #41 from longieirl/fix/40-recursive-scan-default

fix(#40): enable recursive PDF scanning by default

Author: longieirl

docker-compose.yml

@@ -35,6 +35,7 @@ services:
       - EXIT_AFTER_PROCESSING=${EXIT_AFTER_PROCESSING:-true}
       - ENABLE_DYNAMIC_BOUNDARY=${ENABLE_DYNAMIC_BOUNDARY:-false}
       - SORT_BY_DATE=${SORT_BY_DATE:-true}
+      - RECURSIVE_SCAN=${RECURSIVE_SCAN:-true}
       # Output configuration - expense analysis enabled by default (monthly summary requires PAID tier)
       - OUTPUT_FORMATS=${OUTPUT_FORMATS:-csv,json}
       - GENERATE_MONTHLY_SUMMARY=${GENERATE_MONTHLY_SUMMARY:-false}

packages/parser-core/src/bankstatements_core/builders/processor_builder.py

@@ -43,7 +43,7 @@ def __init__(self) -> None:
         self._columns: dict[str, tuple[int | float, int | float]] | None = None
         self._enable_dynamic_boundary: bool = False
         self._sort_by_date: bool = True
-        self._recursive_scan: bool = False
+        self._recursive_scan: bool = True
         self._totals_columns: list[str] | None = None
         self._generate_monthly_summary: bool = True
         self._generate_expense_analysis: bool = True

packages/parser-core/src/bankstatements_core/config/app_config.py

@@ -38,7 +38,7 @@ class AppConfig:
     table_bottom_y: int = 720
     enable_dynamic_boundary: bool = False
     sort_by_date: bool = True
-    recursive_scan: bool = False
+    recursive_scan: bool = True
     totals_columns: list[str] = field(default_factory=list)
     generate_monthly_summary: bool = True
     generate_expense_analysis: bool = True
@@ -128,7 +128,7 @@ def from_env(cls) -> "AppConfig":
                 "ENABLE_DYNAMIC_BOUNDARY", False
             )
             sort_by_date = EnvironmentParser.parse_bool("SORT_BY_DATE", True)
-            recursive_scan = EnvironmentParser.parse_bool("RECURSIVE_SCAN", False)
+            recursive_scan = EnvironmentParser.parse_bool("RECURSIVE_SCAN", True)
             generate_monthly_summary = EnvironmentParser.parse_bool(
                 "GENERATE_MONTHLY_SUMMARY", True
             )

packages/parser-core/src/bankstatements_core/config/processor_config.py

@@ -53,7 +53,7 @@ class ProcessingConfig:
     totals_columns: list[str] | None = None
     generate_monthly_summary: bool = True
     generate_expense_analysis: bool = True
-    recursive_scan: bool = False
+    recursive_scan: bool = True
 
 
 @dataclass

packages/parser-core/src/bankstatements_core/services/pdf_discovery.py

@@ -29,7 +29,7 @@ def __init__(self, entitlements: Entitlements | None = None):
     def discover_pdfs(
         self,
         input_dir: Path,
-        recursive: bool = False,
+        recursive: bool = True,
     ) -> list[Path]:
         """Discover PDF files in input directory.
 

packages/parser-core/tests/test_processor.py

@@ -242,7 +242,7 @@ def test_run_with_mock_data(self):
             result = processor.run()
 
             # Verify the mock was called with correct arguments
-            mock_process.assert_called_once_with(self.input_dir, recursive=False)
+            mock_process.assert_called_once_with(self.input_dir, recursive=True)
 
             # Verify results summary
             self.assertIn("pdf_count", result)