docs(milestone-v1.0): create milestone audit report

Author: web-flow

.planning/v1.0-MILESTONE-AUDIT.md

@@ -0,0 +1,85 @@
+---
+milestone: v1.0
+audited: 2026-03-24T16:15:00Z
+status: passed
+scores:
+  requirements: 5/5
+  phases: 1/1
+  integration: 14/14
+  flows: 1/1
+gaps:
+  requirements: []
+  integration: []
+  flows: []
+tech_debt:
+  - phase: 19-collapse-orchestration-shim
+    items:
+      - "filterwarnings entry in pyproject.toml targets the emitting module (bankstatements_core.pdf_table_extractor) but with stacklevel=2 the warning appears attributed to the caller — suppression may not activate for the 3 legitimate test importers. Non-blocking unless -W error::DeprecationWarning is added to pytest options."
+---
+
+# Milestone v1.0 Audit Report
+
+**Audited:** 2026-03-24
+**Status:** passed
+**Scope:** Phase 19 — Collapse Redundant Orchestration Layers / Retire pdf_table_extractor Shim
+
+## Score Summary
+
+| Dimension | Score | Status |
+|-----------|-------|--------|
+| Requirements | 5/5 | ✓ |
+| Phases verified | 1/1 | ✓ |
+| Integration connections | 14/14 | ✓ |
+| E2E flows | 1/1 | ✓ |
+
+## Requirements Coverage (3-Source Cross-Reference)
+
+| REQ-ID | Description | VERIFICATION.md | SUMMARY frontmatter | Final Status |
+|--------|-------------|-----------------|---------------------|--------------|
+| RFC-19-dead-code | Delete 10 dead private methods from BankStatementProcessor | SATISFIED | listed (19-01) | **satisfied** |
+| RFC-19-inline-passthrough | Inline _process_single_pdf in process_all_pdfs | SATISFIED | listed (19-01) | **satisfied** |
+| RFC-19-shim-redirect | Redirect all production shim imports to real facades | SATISFIED | listed (19-02) | **satisfied** |
+| RFC-19-deprecation-warning | DeprecationWarning on pdf_table_extractor import | SATISFIED | listed (19-02) | **satisfied** |
+| RFC-19-ci-guard | Architecture test enforcing no production shim imports | SATISFIED | listed (19-02) | **satisfied** |
+
+**Orphaned requirements:** None detected.
+
+## Phase Verifications
+
+| Phase | Status | Score | Notes |
+|-------|--------|-------|-------|
+| 19-collapse-orchestration-shim | passed | 9/9 | All must-haves verified; 4 additional shim importers fixed beyond scope |
+
+## Integration Check
+
+**E2E pipeline verified:** BankStatementProcessor → PDFProcessingOrchestrator → ExtractionOrchestrator → extraction_facade → PDFTableExtractor — all 6 links connected.
+
+| Connection | Requirement | Status |
+|------------|-------------|--------|
+| process_all_pdfs → extraction_orchestrator.extract_from_pdf (line 126) | RFC-19-inline-passthrough | WIRED |
+| extraction_orchestrator.py → extraction_facade.extract_tables_from_pdf (line 16) | RFC-19-shim-redirect | WIRED |
+| pdf_extractor.py → validation_facade / extraction_facade (5 inline imports) | RFC-19-shim-redirect | WIRED |
+| processing_facade.py → column_config.get_columns_config | RFC-19-shim-redirect | WIRED |
+| content_density.py → row_classification_facade.classify_row_type | RFC-19-shim-redirect | WIRED |
+| page_validation.py → row_classification_facade.classify_row_type | RFC-19-shim-redirect | WIRED |
+| row_merger.py → row_classification_facade.classify_row_type | RFC-19-shim-redirect | WIRED |
+| pdf_table_extractor.py emits DeprecationWarning at import time | RFC-19-deprecation-warning | WIRED |
+| test_architecture.py scans src/ for shim imports | RFC-19-ci-guard | WIRED |
+
+## Tech Debt
+
+**Phase 19-collapse-orchestration-shim:**
+- `filterwarnings` entry in `pyproject.toml` targets the emitting module (`bankstatements_core.pdf_table_extractor`) but with `stacklevel=2` the warning appears attributed to the caller — suppression may not activate for the 3 legitimate test importers (`test_pdf_table_extractor.py`, `test_env_parsing_logging.py`, `test_template_integration.py`). Non-blocking unless `-W error::DeprecationWarning` is added to pytest options.
+
+## Anti-Patterns
+
+None detected in any modified files.
+
+## Notable Achievements
+
+1. Phase 19-02 exceeded plan scope: architecture guard discovered and fixed 4 additional shim importers (`processing_facade.py`, `content_density.py`, `page_validation.py`, `row_merger.py`) not listed in the plan.
+2. Coverage improved from 91.1% (baseline) to 92.35–92.36%, exceeding the 91% threshold.
+3. Zero shim imports remain in `src/` — the shim is now strictly external-use-only, enforced by CI.
+
+---
+_Auditor: Claude (gsd-integration-checker + orchestrator)_