Skip to content

Commit bb25047

Browse files
committed
fixup! apply feedback
1 parent 0de9093 commit bb25047

27 files changed

+278
-602
lines changed

packages/booter-lb3app/src/__tests__/fixtures/legacy/common/models/coffee-shop.js renamed to packages/booter-lb3app/fixtures/legacy/common/models/coffee-shop.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module.exports = function(CoffeeShop) {
66
var currentHour = currentDate.getHours();
77
var OPEN_HOUR = 6;
88
var CLOSE_HOUR = 20;
9-
console.log('Current hour is %d', currentHour);
9+
1010
var response;
1111
if (currentHour >= OPEN_HOUR && currentHour < CLOSE_HOUR) {
1212
response = 'We are open for business.';
@@ -29,7 +29,6 @@ module.exports = function(CoffeeShop) {
2929
CoffeeShop.findById(shopId, function(err, instance) {
3030
var response = 'Name of coffee shop is ' + instance.name;
3131
cb(null, response);
32-
console.log(response);
3332
});
3433
};
3534
CoffeeShop.remoteMethod('getName', {
@@ -42,4 +41,13 @@ module.exports = function(CoffeeShop) {
4241
},
4342
returns: {arg: 'name', type: 'string'},
4443
});
44+
CoffeeShop.greet = function(cb) {
45+
process.nextTick(function() {
46+
cb(null, 'Hello from this Coffee Shop');
47+
});
48+
};
49+
CoffeeShop.remoteMethod('greet', {
50+
http: {path: '/greet', verb: 'get'},
51+
returns: {type: 'string'},
52+
});
4553
};

packages/booter-lb3app/src/__tests__/fixtures/legacy/common/models/coffee-shop.json renamed to packages/booter-lb3app/fixtures/legacy/common/models/coffee-shop.json

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,14 @@
1717
},
1818
"validations":[],
1919
"relations":{},
20-
"acls":[],
20+
"acls":[
21+
{
22+
"accessType":"EXECUTE",
23+
"principalType":"ROLE",
24+
"principalId":"$unauthenticated",
25+
"permission":"DENY",
26+
"property":"greet"
27+
}
28+
],
2129
"methods":{}
2230
}
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
module.exports = function(app) {
2+
app.get('/coffee', function(req, res) {
3+
res.send('shop');
4+
});
5+
};
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
'use strict';
2+
3+
var loopback = require('loopback');
4+
var boot = require('loopback-boot');
5+
6+
var app = (module.exports = loopback());
7+
8+
boot(app, __dirname, function(err) {
9+
if (err) throw err;
10+
});
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
'use strict';
2+
3+
var loopback = require('loopback');
4+
var boot = require('loopback-boot');
5+
6+
var app = (module.exports = loopback());
7+
8+
app.get('/hello', (req, res) => {
9+
res.send('hello');
10+
});
11+
12+
boot(app, __dirname, function(err) {
13+
if (err) throw err;
14+
});

0 commit comments

Comments
 (0)