[rom,e2e] Add a test for the chip_info

The chip_info became broken without anyone realizing because it
was untested. This test ensures that at least the chip info is
filled and has the expected version.

Signed-off-by: Amaury Pouly <[email protected]>

Author: pamaury

sw/device/silicon_creator/rom/data/rom_e2e_testplan.hjson

@@ -1326,5 +1326,23 @@
       si_stage: NA
       tests: ["rom_e2e_self_hash"]
     }
+
+    {
+      name: rom_e2e_chip_info
+      desc: '''Verify that ROM correctly embeds the chip information and stores it in the boot log
+
+            - Load a ROM_EXT image that will
+              - Print the content of the ROM's chip_info section.
+                - When running as the ROM_EXT, the ROM is still readable, the chip_info is located
+                  at the end of the ROM.
+              - Print the content of the boot log's chip info.
+              - Verify that the two are identical.
+              - Verify that the chip_info's version is the expected one.
+            '''
+      tags: ["rom", "dv", "fpga", "silicon"]
+      stage: V3
+      si_stage: SV2
+      tests: []
+    }
   ]
 }

sw/device/silicon_creator/rom/e2e/BUILD

@@ -477,3 +477,20 @@ opentitan_test(
         "//sw/device/silicon_creator/lib/drivers:rstmgr",
     ],
 )
+
+opentitan_test(
+    name = "rom_e2e_chip_info",
+    srcs = ["chip_info_test.c"],
+    exec_env = {
+        "//hw/top_earlgrey:fpga_cw310_rom_with_fake_keys": None,
+        "//hw/top_earlgrey:fpga_cw310_test_rom": None,
+        "//hw/top_earlgrey:fpga_cw340_rom_with_fake_keys": None,
+        "//hw/top_earlgrey:fpga_cw340_test_rom": None,
+    },
+    deps = [
+        "//sw/device/lib/testing:ret_sram_testutils",
+        "//sw/device/lib/testing/test_framework:ottf_main",
+        "//sw/device/silicon_creator/lib:build_info",
+        "//sw/device/silicon_creator/lib/drivers:retention_sram",
+    ],
+)

sw/device/silicon_creator/rom/e2e/chip_info_test.c

@@ -0,0 +1,44 @@
+// Copyright lowRISC contributors (OpenTitan project).
+// Licensed under the Apache License, Version 2.0, see LICENSE for details.
+// SPDX-License-Identifier: Apache-2.0
+
+#include <stdbool.h>
+
+#include "sw/device/lib/testing/ret_sram_testutils.h"
+#include "sw/device/lib/testing/test_framework/ottf_main.h"
+#include "sw/device/silicon_creator/lib/build_info.h"
+#include "sw/device/silicon_creator/lib/drivers/retention_sram.h"
+
+OTTF_DEFINE_TEST_CONFIG();
+
+extern const char _chip_info_start[];
+
+bool test_main(void) {
+  build_info_t *build_info = (build_info_t *)&_chip_info_start;
+  LOG_INFO("ROM Build Info");
+  LOG_INFO("  Version: %x", build_info->version);
+  LOG_INFO("   SCM lo: %x", build_info->scm_revision.scm_revision_low);
+  LOG_INFO("   SCM hi: %x", build_info->scm_revision.scm_revision_high);
+
+  // Make sure that the version is valid.
+  CHECK(build_info->version == kBuildInfoVersion1);
+
+  bool is_testrom = false;
+  CHECK_STATUS_OK(ret_sram_testutils_is_testrom(&is_testrom));
+  if (!is_testrom) {
+    boot_log_t *boot_log = &retention_sram_get()->creator.boot_log;
+    LOG_INFO("Boot Log Info");
+    LOG_INFO("   SCM lo: %x", boot_log->chip_version.scm_revision_low);
+    LOG_INFO("   SCM hi: %x", boot_log->chip_version.scm_revision_high);
+
+    // Make sure that the boot log correctly reflects the ROM build info.
+    CHECK(build_info->scm_revision.scm_revision_low ==
+          boot_log->chip_version.scm_revision_low);
+    CHECK(build_info->scm_revision.scm_revision_high ==
+          boot_log->chip_version.scm_revision_high);
+  } else {
+    LOG_INFO("Boot log info check skipped (test_rom detected).");
+  }
+
+  return true;
+}