diff --git a/.github/workflows/local-dev-check.yml b/.github/workflows/local-dev-check.yml index 079d921..7a3fed3 100644 --- a/.github/workflows/local-dev-check.yml +++ b/.github/workflows/local-dev-check.yml @@ -14,4 +14,7 @@ jobs: - name: check-content run: | + # download yq + curl https://github.com/mikefarah/yq/releases/download/3.3.0/yq_linux_amd64 -o yq --silent + chmod +x ./yq ./scripts/invalid-docker-ports.sh diff --git a/README.md b/README.md index 4d583ab..f7f951c 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,4 @@ # Welcome to your course 🎉 -boo ### Getting started diff --git a/local_dev/docker-compose.yml b/local_dev/docker-compose.yml index d5a7b03..6c4a4e8 100644 --- a/local_dev/docker-compose.yml +++ b/local_dev/docker-compose.yml @@ -1,5 +1,6 @@ # Important: We should avoid exposing any ports between `20000` and `36384` # see here for reasons why: https://github.com/logrhythm/boreas/tree/master/documentation/troubleshooting +## trigger boo version: '3.7' volumes: diff --git a/scripts/invalid-docker-ports.sh b/scripts/invalid-docker-ports.sh index 19c3f59..0c2a56c 100755 --- a/scripts/invalid-docker-ports.sh +++ b/scripts/invalid-docker-ports.sh @@ -10,8 +10,8 @@ done | sed 's/^"//g' | sed 's/^-//g' | sed '/^$/d' | sed 's/:.*//') # check range of ports for restricted range for port in `echo ${exposed_ports} | sed 's/ /\n/g'` do - #if [ ${port} >= 20000 && ${port} <= 36384 ]; then #if (( ${port} >= 20000 && ${port} <= 36384 )); then + # make it fail: if (( ${port} >= 20000 && ${port} <= 41333 )); then echo "${port} is in a restricted range for Hyper-V" exit 1