Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare vcpkg dependencies in vcpkg.json #13962

Open
AFCMS opened this issue Nov 6, 2023 · 1 comment · May be fixed by #15863
Open

Declare vcpkg dependencies in vcpkg.json #13962

AFCMS opened this issue Nov 6, 2023 · 1 comment · May be fixed by #15863
Labels
@ Build CMake, build scripts, official builds, compiler and linker errors Concept approved Approved by a core dev: PRs welcomed! Feature request Issues that request the addition or enhancement of a feature good first issue

Comments

@AFCMS
Copy link
Contributor

AFCMS commented Nov 6, 2023

Problem

Under Windows, the recommended way of installing Minetest dependencies is vcpkg.

But vcpkg have CMake integration (including working with feature sets) and support the use of vcpkg.json to declare dependencies, version contraints and feature sets , so that CMake can handle itself package installation, IDEs can check installed package versions, etc

Solutions

Add vcpkg.json with dependencies and feature sets, modify CMakeLists.txt to enable integration of feature sets.

Alternatives

None

Additional context

No response

@AFCMS AFCMS added the Feature request Issues that request the addition or enhancement of a feature label Nov 6, 2023
@rubenwardy rubenwardy added @ Build CMake, build scripts, official builds, compiler and linker errors Concept approved Approved by a core dev: PRs welcomed! good first issue labels Nov 6, 2023
@sfan5
Copy link
Collaborator

sfan5 commented Feb 25, 2024

also relates to #14380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Build CMake, build scripts, official builds, compiler and linker errors Concept approved Approved by a core dev: PRs welcomed! Feature request Issues that request the addition or enhancement of a feature good first issue
Projects
None yet
3 participants