Core providers (bazel-contrib#2934)

* refactor: move some providers to new core package

these are the ones we know we want to keep, and will need them to
continue building a usable core package with linking and some basic
rules working.

Author: alexeagle

BUILD.bazel

@@ -54,6 +54,7 @@ bzl_library(
         "//internal/pkg_npm:bzl",
         "//internal/pkg_web:bzl",
         "//internal/providers:bzl",
+        "//nodejs/private/providers:bzl",
     ],
 )
 
@@ -94,6 +95,7 @@ pkg_npm(
         "//internal/providers:package_contents",
         "//internal/runfiles:package_contents",
         "//nodejs:package_contents",
+        "//nodejs/private/providers:package_contents",
         "//third_party/github.com/bazelbuild/bazel:package_contents",
         "//third_party/github.com/bazelbuild/bazel-skylib:package_contents",
         "//third_party/github.com/bazelbuild/bazel/tools/bash/runfiles:package_contents",
@@ -129,6 +131,8 @@ pkg_tar(
     srcs = [
         "LICENSE",
         "README.md",
+        "providers.bzl",
+        "version.bzl",
         "//nodejs:package_contents",
         # TODO(5.0) remove this and depend on real skylib
         "//third_party/github.com/bazelbuild/bazel-skylib:package_contents",

docs/Cypress.html

@@ -218,7 +218,7 @@ Provides data about the build context, like config_setting's
 
 <h4 id="NodeContextInfo-stamp">stamp</h4>
 
- If stamping is enabled 
+ If stamping is enabled for this build 
 
 
 ## NodeRuntimeDepsInfo

docs/Providers.md

@@ -35,7 +35,7 @@ load("//internal/npm_install:npm_install.bzl", _npm_install = "npm_install", _ya
 load("//internal/pkg_npm:pkg_npm.bzl", _pkg_npm = "pkg_npm_macro")
 load("//internal/pkg_web:pkg_web.bzl", _pkg_web = "pkg_web")
 load(
-    "//internal/providers:tree_artifacts.bzl",
+    "//nodejs/private/providers:directory_file_path_info.bzl",
     _directory_file_path = "directory_file_path",
 )
 

index.bzl

@@ -15,7 +15,7 @@
 """Helper function to accept either a label or a directory_file_path as dict
 """
 
-load("//internal/providers:tree_artifacts.bzl", "directory_file_path")
+load("//nodejs/private/providers:directory_file_path_info.bzl", "directory_file_path")
 
 def maybe_directory_file_path(name, value):
     """Pass-through a value or convert a dict with a single key/value pair to a directory_file_path and return its label

internal/common/maybe_directory_file_path.bzl

@@ -12,7 +12,7 @@ runtimes to locate all the first-party packages.
 
 # Can't load from //:providers.bzl directly as that introduces a circular dep
 load("//internal/providers:external_npm_package_info.bzl", "ExternalNpmPackageInfo")
-load("//internal/providers:linkable_package_info.bzl", "LinkablePackageInfo")
+load("//nodejs/private/providers:linkable_package_info.bzl", "LinkablePackageInfo")
 
 def _debug(vars, *args):
     if "VERBOSE_LOGS" in vars.keys():

internal/linker/link_node_modules.bzl

@@ -0,0 +1,25 @@
+"""Provide rules access to the config of the current build
+
+Modelled after _GoContextData in rules_go/go/private/context.bzl
+"""
+
+NodeContextInfo = provider(
+    doc = "Provides data about the build context, like config_setting's",
+    fields = {
+        "stamp": "If stamping is enabled for this build",
+    },
+)
+
+NODE_CONTEXT_ATTRS = {
+    "node_context_data": attr.label(
+        default = "@build_bazel_rules_nodejs//internal:node_context_data",
+        providers = [NodeContextInfo],
+        doc = """Provides info about the build context, such as stamping.
+        
+By default it reads from the bazel command line, such as the `--stamp` argument.
+Use this to override values for this target, such as enabling or disabling stamping.
+You can use the `node_context_data` rule in `@build_bazel_rules_nodejs//internal/node:context.bzl`
+to create a NodeContextInfo.
+""",
+    ),
+}

internal/providers/node_context.bzl

@@ -2,7 +2,9 @@ load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 
 filegroup(
     name = "package_contents",
-    srcs = glob(["*"]) + ["//nodejs/private:package_contents"],
+    srcs = glob(["*"]) + [
+        "//nodejs/private:package_contents",
+    ],
     visibility = ["//:__pkg__"],
 )
 

nodejs/BUILD.bazel

@@ -2,7 +2,9 @@ load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 
 filegroup(
     name = "package_contents",
-    srcs = glob(["*"]),
+    srcs = glob(["*"]) + [
+        "//nodejs/private/providers:package_contents",
+    ],
     visibility = ["//nodejs:__pkg__"],
 )
 

nodejs/private/BUILD.bazel

@@ -0,0 +1,29 @@
+# Copyright 2017 The Bazel Authors. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
+
+bzl_library(
+    name = "bzl",
+    srcs = glob(["*.bzl"]),
+    visibility = ["//visibility:public"],
+)
+
+filegroup(
+    name = "package_contents",
+    srcs = glob(["*.bzl"]) + [
+        "BUILD.bazel",
+    ],
+    visibility = ["//:__subpackages__"],
+)

nodejs/private/providers/BUILD.bazel

@@ -0,0 +1,29 @@
+"Pass information about JavaScript modules between rules"
+
+JSModuleInfo = provider(
+    doc = """JavaScript files and sourcemaps.""",
+    fields = {
+        "direct_sources": "Depset of direct JavaScript files and sourcemaps",
+        "sources": "Depset of direct and transitive JavaScript files and sourcemaps",
+    },
+)
+
+def js_module_info(sources, deps = []):
+    """Constructs a JSModuleInfo including all transitive sources from JSModuleInfo providers in a list of deps.
+
+    Args:
+        sources: direct JS files
+        deps: other targets that provide JSModuleInfo, typically from the deps attribute
+
+    Returns:
+        a single JSModuleInfo.
+    """
+    transitive_depsets = [sources]
+    for dep in deps:
+        if JSModuleInfo in dep:
+            transitive_depsets.append(dep[JSModuleInfo].sources)
+
+    return JSModuleInfo(
+        direct_sources = sources,
+        sources = depset(transitive = transitive_depsets),
+    )

internal/providers/declaration_info.bzl renamed to nodejs/private/providers/declaration_info.bzl

@@ -0,0 +1,29 @@
+"""
+Public providers, aspects and helpers that are shipped in the built-in rules_nodejs repository.
+"""
+
+load(
+    "//nodejs/private/providers:declaration_info.bzl",
+    _DeclarationInfo = "DeclarationInfo",
+    _declaration_info = "declaration_info",
+)
+load(
+    "//nodejs/private/providers:js_providers.bzl",
+    _JSModuleInfo = "JSModuleInfo",
+    _js_module_info = "js_module_info",
+)
+load(
+    "//nodejs/private/providers:linkable_package_info.bzl",
+    _LinkablePackageInfo = "LinkablePackageInfo",
+)
+load(
+    "//nodejs/private/providers:directory_file_path_info.bzl",
+    _DirectoryFilePathInfo = "DirectoryFilePathInfo",
+)
+
+DeclarationInfo = _DeclarationInfo
+declaration_info = _declaration_info
+JSModuleInfo = _JSModuleInfo
+js_module_info = _js_module_info
+LinkablePackageInfo = _LinkablePackageInfo
+DirectoryFilePathInfo = _DirectoryFilePathInfo

internal/providers/tree_artifacts.bzl renamed to nodejs/private/providers/directory_file_path_info.bzl

@@ -19,7 +19,7 @@ Users should not load files under "/internal"
 """
 
 load(
-    "//internal/providers:declaration_info.bzl",
+    "//nodejs/private/providers:declaration_info.bzl",
     _DeclarationInfo = "DeclarationInfo",
     _declaration_info = "declaration_info",
 )
@@ -38,7 +38,7 @@ load(
     _js_named_module_info = "js_named_module_info",
 )
 load(
-    "//internal/providers:linkable_package_info.bzl",
+    "//nodejs/private/providers:linkable_package_info.bzl",
     _LinkablePackageInfo = "LinkablePackageInfo",
 )
 load(
@@ -47,9 +47,17 @@ load(
     _run_node = "run_node",
 )
 load(
-    "//internal/providers:tree_artifacts.bzl",
+    "//nodejs/private/providers:directory_file_path_info.bzl",
     _DirectoryFilePathInfo = "DirectoryFilePathInfo",
 )
+load(
+    "//internal/providers:node_context.bzl",
+    _NODE_CONTEXT_ATTRS = "NODE_CONTEXT_ATTRS",
+    _NodeContextInfo = "NodeContextInfo",
+)
+
+NodeContextInfo = _NodeContextInfo
+NODE_CONTEXT_ATTRS = _NODE_CONTEXT_ATTRS
 
 DeclarationInfo = _DeclarationInfo
 declaration_info = _declaration_info
@@ -67,29 +75,6 @@ ExternalNpmPackageInfo = _ExternalNpmPackageInfo
 NpmPackageInfo = _ExternalNpmPackageInfo
 node_modules_aspect = _node_modules_aspect
 LinkablePackageInfo = _LinkablePackageInfo
-
-#Modelled after _GoContextData in rules_go/go/private/context.bzl
-NodeContextInfo = provider(
-    doc = "Provides data about the build context, like config_setting's",
-    fields = {
-        "stamp": "If stamping is enabled",
-    },
-)
-
-NODE_CONTEXT_ATTRS = {
-    "node_context_data": attr.label(
-        default = "@build_bazel_rules_nodejs//internal:node_context_data",
-        providers = [NodeContextInfo],
-        doc = """Provides info about the build context, such as stamping.
-        
-By default it reads from the bazel command line, such as the `--stamp` argument.
-Use this to override values for this target, such as enabling or disabling stamping.
-You can use the `node_context_data` rule in `@build_bazel_rules_nodejs//internal/node:context.bzl`
-to create a NodeContextInfo.
-""",
-    ),
-}
-
 NodeRuntimeDepsInfo = _NodeRuntimeDepsInfo
 run_node = _run_node
 DirectoryFilePathInfo = _DirectoryFilePathInfo