Skip to content

Commit 8bd8fe0

Browse files
authored
Breaking change: Don't extract value from 1-length dict (#399)
* dont extract value from dict * fix test * fix
1 parent 92f6b0d commit 8bd8fe0

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

gokart/task.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -290,10 +290,7 @@ def _load(targets):
290290
return {k: _load(t) for k, t in targets.items()}
291291
return targets.load()
292292

293-
data = _load(self._get_input_targets(target))
294-
if target is None and isinstance(data, dict) and len(data) == 1:
295-
return list(data.values())[0]
296-
return data
293+
return _load(self._get_input_targets(target))
297294

298295
@overload
299296
def load_generator(self, target: Union[None, str, TargetOnKart] = None) -> Generator[Any, None, None]: ...

test/test_task_on_kart.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ def test_load_with_single_dict_target(self):
267267

268268
data = task.load()
269269
target.load.assert_called_once()
270-
self.assertEqual(data, 1)
270+
self.assertEqual(data, {'target_key': 1})
271271

272272
def test_load_with_keyword(self):
273273
task = _DummyTask()

0 commit comments

Comments
 (0)