Skip to content

Commit 29db047

Browse files
committed
Update the Windows runner on all workflows to windows-2022
Support has been dropped for `windows-2019` runner image. `windows-2019` is not a requirement anymore since building for Node `v16` has also been dropped for a while.
1 parent b66eca9 commit 29db047

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

.github/workflows/prebuild-test-all.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
os:
1616
- macos-13
1717
- macos-14
18-
- windows-2019
18+
- windows-2022
1919
name: Prebuild on ${{ matrix.os }}
2020
runs-on: ${{ matrix.os }}
2121
steps:
@@ -30,7 +30,7 @@ jobs:
3030
- run: npm install --ignore-scripts
3131
- run: ${{ env.NODE_BUILD_CMD }}
3232
- run: ${{ env.ELECTRON_BUILD_CMD }}
33-
- if: matrix.os == 'windows-2019'
33+
- if: matrix.os == 'windows-2022'
3434
run: |
3535
${{ env.NODE_BUILD_CMD }} --arch ia32
3636
${{ env.NODE_BUILD_CMD }} --arch arm64

.github/workflows/prebuild-test.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ on:
2121
description: 'Test on ubuntu-22.04'
2222
type: boolean
2323
default: true
24-
windows-2019:
25-
description: 'Test on windows-2019'
24+
windows-2022:
25+
description: 'Test on windows-2022'
2626
type: boolean
2727
default: true
2828
macos-13:
@@ -41,7 +41,7 @@ env:
4141

4242
jobs:
4343
input-setup:
44-
if: inputs['ubuntu-22.04'] == true || inputs['windows-2019'] == true || inputs['macos-13'] == true
44+
if: inputs['ubuntu-22.04'] == true || inputs['windows-2022'] == true || inputs['macos-13'] == true
4545
name: Preparing tests
4646
runs-on: ubuntu-latest
4747
outputs:
@@ -53,7 +53,7 @@ jobs:
5353
INPUTS='${{ toJSON(inputs) }}'
5454
PLATFORMS='{"os":[]}'
5555
56-
for os in 'ubuntu-22.04' 'windows-2019' 'macos-13'
56+
for os in 'ubuntu-22.04' 'windows-2022' 'macos-13'
5757
do
5858
if [ "$(jq ".[\"$os\"]" <<< "$INPUTS")" = "true" ]; then PLATFORMS=$(jq -c ".os += [\"$os\"]" <<< "$PLATFORMS"); fi
5959
done
@@ -85,7 +85,7 @@ jobs:
8585
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 100 --slave /usr/bin/g++ g++ /usr/bin/g++-10 --slave /usr/bin/gcov gcov /usr/bin/gcov-10
8686
- run: npm install --ignore-scripts
8787
- run: ${{ env.TEST_COMMAND }}
88-
- if: matrix.os == 'windows-2019' && inputs.arm == true
88+
- if: matrix.os == 'windows-2022' && inputs.arm == true
8989
run: ${{ env.TEST_COMMAND }} --arch arm64
9090

9191
prebuild-test-mac-arm64:

.github/workflows/prebuild.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
os:
1818
- macos-13
1919
- macos-14
20-
- windows-2019
20+
- windows-2022
2121
name: Prebuild on ${{ matrix.os }}
2222
runs-on: ${{ matrix.os }}
2323
steps:
@@ -32,7 +32,7 @@ jobs:
3232
- run: npm install --ignore-scripts
3333
- run: ${{ env.NODE_BUILD_CMD }}
3434
- run: ${{ env.ELECTRON_BUILD_CMD }}
35-
- if: matrix.os == 'windows-2019'
35+
- if: matrix.os == 'windows-2022'
3636
run: |
3737
${{ env.NODE_BUILD_CMD }} --arch ia32
3838
${{ env.NODE_BUILD_CMD }} --arch arm64

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- ubuntu-22.04
2020
- macos-13
2121
- macos-14
22-
- windows-2019
22+
- windows-2022
2323
node:
2424
- 20
2525
- 22

0 commit comments

Comments
 (0)