fix: address PR review feedback

Author: jaissica12

src/forwarders.interfaces.ts

@@ -39,6 +39,11 @@ export interface UnregisteredKit {
     suffix?: string;
 }
 
+export interface SideloadedKit {
+    kitInstance: UnregisteredKit;
+    filterDictionary: IKitFilterSettings;
+}
+
 // The state of the kit after being added to forwarderConstructors in the CDN
 // or after registered to SDKConfig.kits via NPM
 // Sideloaded Kits would also be considered registered
@@ -190,7 +195,7 @@ export interface IForwarders {
         configuration: IKitConfigs,
         kits: Dictionary<RegisteredKit>
     ): void;
-    processSideloadedKits(mpConfig: IConfigResponse): void;
+    processSideloadedKits(mpConfig: IConfigResponse & { sideloadedKits?: SideloadedKit[] }): void;
     configureSideloadedKit(kitConstructor: RegisteredKit): void;
     returnConfiguredKit(
         forwarder: RegisteredKit,

src/forwarders.ts

@@ -1,5 +1,5 @@
 import filteredMparticleUser from './filteredMparticleUser';
-import { isEmpty, extend } from './utils';
+import { isEmpty, extend, Dictionary } from './utils';
 import KitFilterHelper from './kitFilterHelper';
 import Constants from './constants';
 import APIClient, { IForwardingStatsData } from './apiClient';
@@ -19,7 +19,7 @@ import {
     MPForwarder,
     RegisteredKit,
     forwardingStatsCallback as ForwardingStatsCallback,
-    ConfiguredKit,
+    SideloadedKit,
 } from './forwarders.interfaces';
 import {
     IConfigResponse,
@@ -31,7 +31,6 @@ import { IPixelConfiguration } from './cookieSyncManager';
 import { Batch } from '@mparticle/event-models';
 import { IMParticleUser, ISDKUserIdentity } from './identity-user-interfaces';
 import KitBlocker from './kitBlocking';
-import { Dictionary } from './utils';
 
 const { Modify, Identify, Login, Logout } = Constants.IdentityMethods;
 
@@ -238,13 +237,7 @@ export default function Forwarders(
                 event.EventCategory
             );
 
-            for (
-                let i = 0;
-                i < mpInstance._Store.activeForwarders.length;
-                i++
-            ) {
-                const forwarder = mpInstance._Store.activeForwarders[i];
-
+            for (const forwarder of mpInstance._Store.activeForwarders) {
                 if (
                     (isBlockedByForwardingRule as Function)(
                         event.EventDataType,
@@ -356,7 +349,7 @@ export default function Forwarders(
                 const result = forwarder.processBatch(batchCopy);
 
                 if (result) {
-                    mpInstance.Logger.verbose(result as string);
+                    mpInstance.Logger.verbose(result);
                 }
             } catch (e) {
                 mpInstance.Logger.verbose(e as string);
@@ -641,7 +634,7 @@ export default function Forwarders(
     // there being a separate process for MP configured kits and
     // sideloaded kits, this will need to be refactored.
     this.processSideloadedKits = function(
-        mpConfig: IConfigResponse & { sideloadedKits?: { kitInstance: { register: Function; name: string }; filterDictionary: IKitFilterSettings }[] }
+        mpConfig: IConfigResponse & { sideloadedKits?: SideloadedKit[] }
     ): void {
         try {
             if (Array.isArray(mpConfig.sideloadedKits)) {

src/sdkRuntimeModels.ts

@@ -195,7 +195,7 @@ export interface MParticleWebSDK {
     configurePixel(config: IPixelConfiguration): void;
     endSession(): void;
     init(apiKey: string, config: SDKInitConfig, instanceName?: string): void;
-    _getActiveForwarders(): MPForwarder[];
+    _getActiveForwarders(): ConfiguredKit[];
     _getIntegrationDelays(): IntegrationDelays;
     _setIntegrationDelay(module: number, shouldDelayIntegration: boolean): void;
     _setWrapperSDKInfo(name: WrapperSDKTypes, version: string): void;
@@ -390,7 +390,7 @@ export interface SDKHelpersApi {
         name: string
     ): Dictionary<string> | null;
     filterUserIdentities?(
-        userIdentitiesObject: Record<string, string>,
+        userIdentitiesObject: Dictionary<string>,
         filterList: number[]
     ): ISDKUserIdentity[];
     Validators: typeof Validators;