Skip to content

Commit fb76baa

Browse files
MarijnS95MarijnS95
committed
Metal: Misc non-unsafe translation fixes
1 parent a63e4ef commit fb76baa

File tree

4 files changed

+92
-5
lines changed

4 files changed

+92
-5
lines changed

‎crates/dispatch2/src/object.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ enum_with_val! {
4444
#[allow(missing_docs)] // TODO
4545
pub const QOS_MIN_RELATIVE_PRIORITY: i32 = -15;
4646

47-
/// Error returned by [DispatchObject::set_qos_class_floor].
47+
/// Error returned by [`DispatchObject::set_qos_class_floor()`].
4848
#[derive(Debug, Copy, Clone, PartialEq, Eq, PartialOrd, Ord)]
4949
#[non_exhaustive]
5050
pub enum QualityOfServiceClassFloorError {

‎framework-crates/objc2-metal/src/device.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ use objc2_foundation::NSArray;
1010
/// application based on whatever criteria it deems appropriate.
1111
///
1212
/// On iOS, tvOS and visionOS, this API returns an array containing the same
13-
/// device that MTLCreateSystemDefaultDevice would have returned, or an empty
13+
/// device that [`MTLCreateSystemDefaultDevice()`] would have returned, or an empty
1414
/// array if it would have failed.
1515
#[inline]
1616
pub extern "C-unwind" fn MTLCopyAllDevices() -> Retained<NSArray<ProtocolObject<dyn MTLDevice>>> {

‎framework-crates/objc2-metal/src/lib.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
//!
1212
//! [apple-doc]: https://developer.apple.com/documentation/xcode/validating-your-apps-metal-api-usage/.
1313
//!
14-
//! NOTE: To use [`MTLCreateSystemDefaultDevice`] you need to link to
14+
//! NOTE: To use [`MTLCreateSystemDefaultDevice()`] you need to link to
1515
//! `CoreGraphics`, this can be done by using `objc2-core-graphics`, or by
1616
//! doing:
1717
//! ```rust

‎framework-crates/objc2-metal/translation-config.toml‎

Lines changed: 89 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ class.MTLInstanceAccelerationStructureDescriptor.methods."setInstancedAccelerati
5959
class.MTLInstanceAccelerationStructureDescriptor.methods."setInstanceCount:".unsafe = false
6060
class.MTLInstanceAccelerationStructureDescriptor.methods."setInstanceDescriptorBuffer:".unsafe = false
6161

62+
protocol.MTLAccelerationStructureCommandEncoder.methods."updateFence:".unsafe = false
63+
protocol.MTLAccelerationStructureCommandEncoder.methods."waitForFence:".unsafe = false
6264
protocol.MTLAccelerationStructureCommandEncoder.methods."buildAccelerationStructure:descriptor:scratchBuffer:scratchBufferOffset:".unsafe = false
6365
protocol.MTLAccelerationStructureCommandEncoder.methods."writeCompactedAccelerationStructureSize:toBuffer:offset:".unsafe = false
6466
protocol.MTLAccelerationStructureCommandEncoder.methods."copyAndCompactAccelerationStructure:toAccelerationStructure:".unsafe = false
@@ -99,11 +101,19 @@ class.MTLArgument.methods.textureType.unsafe = false
99101
class.MTLArgument.methods.textureDataType.unsafe = false
100102

101103
class.MTLArgumentDescriptor.methods.argumentDescriptor.unsafe = false
104+
class.MTLArgumentDescriptor.methods.dataType.unsafe = false
102105
class.MTLArgumentDescriptor.methods."setDataType:".unsafe = false
106+
class.MTLArgumentDescriptor.methods.index.unsafe = false
103107
class.MTLArgumentDescriptor.methods."setIndex:".unsafe = false
108+
class.MTLArgumentDescriptor.methods.arrayLength.unsafe = false
109+
class.MTLArgumentDescriptor.methods.access.unsafe = false
104110
class.MTLArgumentDescriptor.methods."setAccess:".unsafe = false
105111
# class.MTLArgumentDescriptor.methods."setArrayLength:".unsafe = false
112+
class.MTLArgumentDescriptor.methods.textureType.unsafe = false
106113
class.MTLArgumentDescriptor.methods."setTextureType:".unsafe = false
114+
class.MTLArgumentDescriptor.methods.constantBlockAlignment.unsafe = false
115+
class.MTLArgumentDescriptor.methods."setConstantBlockAlignment:".unsafe = false
116+
class.MTLArgumentDescriptor.methods.new.unsafe = false
107117

108118
protocol.MTLBuffer.methods.length.unsafe = false
109119
protocol.MTLBuffer.methods.contents.unsafe = false
@@ -125,6 +135,7 @@ class.MTLCaptureDescriptor.methods."setOutputURL:".unsafe = false
125135
protocol.MTLCaptureScope.methods.beginScope.unsafe = false
126136
protocol.MTLCaptureScope.methods.endScope.unsafe = false
127137
protocol.MTLCaptureScope.methods.label.unsafe = false
138+
protocol.MTLCaptureScope.methods."setLabel:".unsafe = false
128139

129140
# Note: MTLCaptureManager is not documented thread-safe, so
130141
# +sharedCaptureManager is not safe either, since we do interior mutation here.
@@ -140,30 +151,56 @@ class.MTLCaptureManager.methods.defaultCaptureScope.unsafe = false
140151
class.MTLCaptureManager.methods."setDefaultCaptureScope:".unsafe = false
141152
class.MTLCaptureManager.methods.isCapturing.unsafe = false
142153

154+
protocol.MTLCommandBuffer.methods.device.unsafe = false
155+
protocol.MTLCommandBuffer.methods.commandQueue.unsafe = false
156+
protocol.MTLCommandBuffer.methods.retainedReferences.unsafe = false
157+
protocol.MTLCommandBuffer.methods.errorOptions.unsafe = false
143158
protocol.MTLCommandBuffer.methods.label.unsafe = false
144159
protocol.MTLCommandBuffer.methods."setLabel:".unsafe = false
160+
protocol.MTLCommandBuffer.methods.kernelStartTime.unsafe = false
161+
protocol.MTLCommandBuffer.methods.kernelEndTime.unsafe = false
162+
protocol.MTLCommandBuffer.methods.logs.unsafe = false
163+
protocol.MTLCommandBuffer.methods.GPUStartTime.unsafe = false
164+
protocol.MTLCommandBuffer.methods.GPUEndTime.unsafe = false
145165
protocol.MTLCommandBuffer.methods.enqueue.unsafe = false
146166
protocol.MTLCommandBuffer.methods.commit.unsafe = false
147167
protocol.MTLCommandBuffer.methods."presentDrawable:".unsafe = false
168+
# protocol.MTLCommandBuffer.methods."presentDrawable:atTime:".unsafe = false
169+
# protocol.MTLCommandBuffer.methods."presentDrawable:afterMinimumDuration:".unsafe = false
148170
protocol.MTLCommandBuffer.methods.waitUntilScheduled.unsafe = false
149171
# TODO once blocks are better
150172
# protocol.MTLCommandBuffer.methods."addCompletedHandler:".unsafe = false
173+
protocol.MTLCommandBuffer.methods.waitUntilCompleted.unsafe = false
151174
protocol.MTLCommandBuffer.methods.status.unsafe = false
175+
protocol.MTLCommandBuffer.methods.error.unsafe = false
152176
protocol.MTLCommandBuffer.methods.blitCommandEncoder.unsafe = false
153177
protocol.MTLCommandBuffer.methods."renderCommandEncoderWithDescriptor:".unsafe = false
178+
protocol.MTLCommandBuffer.methods."computeCommandEncoderWithDescriptor:".unsafe = false
179+
protocol.MTLCommandBuffer.methods."blitCommandEncoderWithDescriptor:".unsafe = false
154180
protocol.MTLCommandBuffer.methods.computeCommandEncoder.unsafe = false
155181
protocol.MTLCommandBuffer.methods."computeCommandEncoderWithDispatchType:".unsafe = false
156182
protocol.MTLCommandBuffer.methods."encodeWaitForEvent:value:".unsafe = false
157183
protocol.MTLCommandBuffer.methods."encodeSignalEvent:value:".unsafe = false
158184
protocol.MTLCommandBuffer.methods."parallelRenderCommandEncoderWithDescriptor:".unsafe = false
185+
protocol.MTLCommandBuffer.methods.resourceStateCommandEncoder.unsafe = false
186+
protocol.MTLCommandBuffer.methods."resourceStateCommandEncoderWithDescriptor:".unsafe = false
159187
protocol.MTLCommandBuffer.methods.accelerationStructureCommandEncoder.unsafe = false
188+
protocol.MTLCommandBuffer.methods."accelerationStructureCommandEncoderWithDescriptor:".unsafe = false
160189
protocol.MTLCommandBuffer.methods."pushDebugGroup:".unsafe = false
161190
protocol.MTLCommandBuffer.methods.popDebugGroup.unsafe = false
191+
protocol.MTLCommandBuffer.methods."useResidencySet:".unsafe = false
192+
# protocol.MTLCommandBuffer.methods."useResidencySets:count:".unsafe = false
162193

163194
protocol.MTLCommandQueue.methods.label.unsafe = false
164195
protocol.MTLCommandQueue.methods."setLabel:".unsafe = false
165196
protocol.MTLCommandQueue.methods.device.unsafe = false
166197
protocol.MTLCommandQueue.methods.commandBuffer.unsafe = false
198+
protocol.MTLCommandQueue.methods."commandBufferWithDescriptor:".unsafe = false
199+
protocol.MTLCommandQueue.methods.commandBufferWithUnretainedReferences.unsafe = false
200+
protocol.MTLCommandQueue.methods."addResidencySet:".unsafe = false
201+
# protocol.MTLCommandQueue.methods."addResidencySets:count:".unsafe = false
202+
protocol.MTLCommandQueue.methods."removeResidencySet:".unsafe = false
203+
# protocol.MTLCommandQueue.methods."removeResidencySets:count:".unsafe = false
167204

168205
class.MTLStencilDescriptor.methods.stencilCompareFunction.unsafe = false
169206
class.MTLStencilDescriptor.methods."setStencilCompareFunction:".unsafe = false
@@ -248,14 +285,19 @@ protocol.MTLDevice.methods."newBinaryArchiveWithDescriptor:error:".unsafe = fals
248285
protocol.MTLDevice.methods.supportsRaytracing.unsafe = false
249286
protocol.MTLDevice.methods."accelerationStructureSizesWithDescriptor:".unsafe = false
250287
protocol.MTLDevice.methods."newAccelerationStructureWithSize:".unsafe = false
288+
protocol.MTLDevice.methods."newAccelerationStructureWithDescriptor:".unsafe = false
289+
protocol.MTLDevice.methods."heapAccelerationStructureSizeAndAlign:size:".unsafe = false
290+
protocol.MTLDevice.methods."heapAccelerationStructureSizeAndAlign:descriptor:".unsafe = false
251291
protocol.MTLDevice.methods.supportsFunctionPointers.unsafe = false
252292

253293
protocol.MTLDrawable.methods.present.unsafe = false
254294
protocol.MTLDrawable.methods.drawableID.unsafe = false
255295

296+
protocol.MTLCommandEncoder.methods.device.unsafe = false
256297
protocol.MTLCommandEncoder.methods.label.unsafe = false
257298
protocol.MTLCommandEncoder.methods."setLabel:".unsafe = false
258299
protocol.MTLCommandEncoder.methods.endEncoding.unsafe = false
300+
protocol.MTLCommandEncoder.methods."barrierAfterQueueStages:beforeStages:".unsafe = false
259301
protocol.MTLCommandEncoder.methods."insertDebugSignpost:".unsafe = false
260302
protocol.MTLCommandEncoder.methods."pushDebugGroup:".unsafe = false
261303
protocol.MTLCommandEncoder.methods.popDebugGroup.unsafe = false
@@ -282,15 +324,26 @@ protocol.MTLRenderCommandEncoder.methods."setDepthStencilState:".unsafe = false
282324
protocol.MTLRenderCommandEncoder.methods."setStencilReferenceValue:".unsafe = false
283325
protocol.MTLRenderCommandEncoder.methods."setStencilFrontReferenceValue:backReferenceValue:".unsafe = false
284326
protocol.MTLRenderCommandEncoder.methods."setVisibilityResultMode:offset:".unsafe = false
327+
protocol.MTLRenderCommandEncoder.methods."setDepthStoreAction:".unsafe = false
328+
protocol.MTLRenderCommandEncoder.methods."setStencilStoreAction:".unsafe = false
329+
protocol.MTLRenderCommandEncoder.methods."setDepthStoreActionOptions:".unsafe = false
330+
protocol.MTLRenderCommandEncoder.methods."setStencilStoreActionOptions:".unsafe = false
285331
# drawPrimitives:...
286332
# ...
287333
protocol.MTLRenderCommandEncoder.methods."updateFence:afterStages:".unsafe = false
288334
protocol.MTLRenderCommandEncoder.methods."waitForFence:beforeStages:".unsafe = false
335+
protocol.MTLRenderCommandEncoder.methods."setTessellationFactorScale:".unsafe = false
336+
protocol.MTLRenderCommandEncoder.methods.tileWidth.unsafe = false
337+
protocol.MTLRenderCommandEncoder.methods.tileHeight.unsafe = false
289338
# setThreadgroupMemoryLength:offset:atIndex:
290339
protocol.MTLRenderCommandEncoder.methods."useResource:usage:".unsafe = false
291340
protocol.MTLRenderCommandEncoder.methods."useResource:usage:stages:".unsafe = false
292341
protocol.MTLRenderCommandEncoder.methods."useHeap:".unsafe = false
293342
protocol.MTLRenderCommandEncoder.methods."useHeap:stages:".unsafe = false
343+
# executeCommandsInBuffer:withRange:
344+
# executeCommandsInBuffer:indirectBuffer:indirectBufferOffset:
345+
protocol.MTLRenderCommandEncoder.methods."memoryBarrierWithScope:afterStages:beforeStages:".unsafe = false
346+
# sampleCountersInBuffer:atSampleIndex:withBarrier: is the GPU-based sample indes OOB sound?
294347

295348
# TODO: Verify out-of-bounds access is sound.
296349
protocol.MTLBlitCommandEncoder.methods."synchronizeResource:".unsafe = false
@@ -302,17 +355,28 @@ protocol.MTLBlitCommandEncoder.methods."waitForFence:".unsafe = false
302355
protocol.MTLBlitCommandEncoder.methods."optimizeContentsForGPUAccess:".unsafe = false
303356
# optimizeContentsForGPUAccess:slice:level:
304357

358+
protocol.MTLComputeCommandEncoder.methods.dispatchType.unsafe = false
305359
# TODO: Verify out-of-bounds access is sound.
306360
protocol.MTLComputeCommandEncoder.methods."setComputePipelineState:".unsafe = false
307361
# setBuffer:...
308362
# setIntersectionFunctionTable:atBufferIndex:
363+
# protocol.MTLComputeCommandEncoder.methods."setThreadGroupMemoryLength:atIndex:".unsafe = false
364+
protocol.MTLComputeCommandEncoder.methods."setImageBlockWidth:Height:".unsafe = false
365+
protocol.MTLComputeCommandEncoder.methods."setStageInRegion:".unsafe = false
366+
# TODO: OOB offset?
367+
protocol.MTLComputeCommandEncoder.methods."setStageInRegionWithIndirectBuffer:indirectBufferOffset:".unsafe = false
309368
protocol.MTLComputeCommandEncoder.methods."dispatchThreadgroups:threadsPerThreadgroup:".unsafe = false
310369
# dispatchThreadgroupsWithIndirectBuffer:indirectBufferOffset:threadsPerThreadgroup:
311370
protocol.MTLComputeCommandEncoder.methods."dispatchThreads:threadsPerThreadgroup:".unsafe = false
312371
protocol.MTLComputeCommandEncoder.methods."updateFence:".unsafe = false
313372
protocol.MTLComputeCommandEncoder.methods."waitForFence:".unsafe = false
314373
protocol.MTLComputeCommandEncoder.methods."useResource:usage:".unsafe = false
315374
protocol.MTLComputeCommandEncoder.methods."useHeap:".unsafe = false
375+
# TODO: GPU-side range?
376+
# protocol.MTLComputeCommandEncoder.methods."executeCommandsInBuffer:withRange:".unsafe = false
377+
# protocol.MTLComputeCommandEncoder.methods."executeCommandsInBuffer:indirectBuffer:indirectBufferOffset:".unsafe = false
378+
protocol.MTLComputeCommandEncoder.methods."memoryBarrierWithScope:".unsafe = false
379+
# sampleCountersInBuffer:atSampleIndex:withBarrier: is the GPU-based sample indes OOB sound?
316380

317381
# TODO: Verify out-of-bounds access is sound.
318382
protocol.MTLArgumentEncoder.methods.encodedLength.unsafe = false
@@ -349,8 +413,12 @@ protocol.MTLHeap.methods."newTextureWithDescriptor:".unsafe = false
349413
protocol.MTLHeap.methods."setPurgeableState:".unsafe = false
350414
# TODO: type
351415
# TODO: Verify that offset out-of-bounds is sound.
352-
# newBufferWithLength:options:offset:
353-
# newTextureWithDescriptor:offset:
416+
protocol.MTLHeap.methods."newBufferWithLength:options:offset:".unsafe = false
417+
protocol.MTLHeap.methods."newTextureWithDescriptor:offset:".unsafe = false
418+
protocol.MTLHeap.methods."newAccelerationStructureWithSize:".unsafe = false
419+
protocol.MTLHeap.methods."newAccelerationStructureWithSize:offset:".unsafe = false
420+
protocol.MTLHeap.methods."newAccelerationStructureWithDescriptor:".unsafe = false
421+
protocol.MTLHeap.methods."newAccelerationStructureWithDescriptor:offset:".unsafe = false
354422

355423
class.MTLIndirectCommandBufferDescriptor.methods.commandTypes.unsafe = false
356424
class.MTLIndirectCommandBufferDescriptor.methods."setCommandTypes:".unsafe = false
@@ -558,6 +626,25 @@ class.MTLRenderPassDescriptor.methods.rasterizationRateMap.unsafe = false
558626
class.MTLRenderPassDescriptor.methods."setRasterizationRateMap:".unsafe = false
559627
class.MTLRenderPassDescriptor.methods.sampleBufferAttachments.unsafe = false
560628

629+
class.MTLResidencySetDescriptor.methods.label.unsafe = false
630+
class.MTLResidencySetDescriptor.methods."setLabel:".unsafe = false
631+
class.MTLResidencySetDescriptor.methods.initialCapacity.unsafe = false
632+
class.MTLResidencySetDescriptor.methods."setInitialCapacity:".unsafe = false
633+
634+
protocol.MTLResidencySet.methods.device.unsafe = false
635+
protocol.MTLResidencySet.methods.label.unsafe = false
636+
protocol.MTLResidencySet.methods."setLabel:".unsafe = false
637+
protocol.MTLResidencySet.methods.allocatedSize.unsafe = false
638+
protocol.MTLResidencySet.methods.requestResidency.unsafe = false
639+
protocol.MTLResidencySet.methods.endResidency.unsafe = false
640+
protocol.MTLResidencySet.methods."addAllocation:".unsafe = false
641+
protocol.MTLResidencySet.methods."removeAllocation:".unsafe = false
642+
protocol.MTLResidencySet.methods.removeAllAllocations.unsafe = false
643+
protocol.MTLResidencySet.methods."containsAllocation:".unsafe = false
644+
protocol.MTLResidencySet.methods.allAllocations.unsafe = false
645+
protocol.MTLResidencySet.methods.allocationCount.unsafe = false
646+
protocol.MTLResidencySet.methods.commit.unsafe = false
647+
561648
protocol.MTLResource.methods.label.unsafe = false
562649
protocol.MTLResource.methods."setLabel:".unsafe = false
563650
protocol.MTLResource.methods.device.unsafe = false

0 commit comments

Comments
 (0)