Cannot edit group menu

[misterjoonas]

After creating a menu into a group I get access denied at
https://local.site.com/en/group/1/menu/1
And with the latest branch the menu is hidden in the menu list, so I can't access it from there either.
Going to https://local.site.com/en/group/1/menu/1/edit will also give a "You are not authorized to access this page." message.

Deleting a menu doesn't work either at https://local.site.com/en/group/1/menu/1/delete

[maebug]

Okay, this is kind of an interesting issue that I wanted to get your take on. The edit forms and stuff work, but here's the catch: I wasn't sure what URLs I should use for editing menu forms so it's a little obscure at the moment. This issue has entirely to do with editing menu links i.e. we'd sort of run into this problem with the one-menu approach as well.

Currently to edit a menu you have to go to 'group/menu/manage/{menu-machine-name}'. Obviously I'd like to change this to be more like 'group/{group-id}/menu/{menu-machine-name}' but I wasn't sure what we'd do for menu links. Currently the URL for the menu link edit page is 'group/menu/item/{menu_link_id}/edit'

I'm thinking that having 'group/{group}/menu' display a page containing a view of all menus associated with a group and links to their edit/delete forms. If there is only one menu in the group then I'd just as well have this page redirect to that one menu's edit page (since there is also a delete button on menu edit pages). This would have URL 'group/{group}/menu/{menu}'

For menu links, I'm thinking we have the URLs be 'group/{group}/menu/item/{menu_link_content}/edit' and 'group/{group}/menu/item/{menu_link_content}/delete' This would be somewhat consistent with core's menu and menu link routes.

What do you think? I'm open to changes here, and my goal is to make the most intuitive URLs possible.

[misterjoonas]

I'm not that familiar with D8 menu items and routing, it feels like it would be nice to have the group context there if somebody want to display the group which menu items or menu is being edited. If it's easy to override the core behavior, it sounds good to me.

[maebug]

Awesome! Once I take care of the other open issue, I'll get this taken care of! Thanks for all your help on this, by the way. There's a lot to keep track of so some of these issues you've brought up are either things I haven't thought about or haven't had time to discover yet.