Merge branch 'ACP2E-3448' of https://github.com/adobe-commerce-tier-4/inventory into PR-11-19-2024

Author: chittima

InventoryImportExport/Model/Import/Validator/QtyValidator.php

@@ -1,7 +1,7 @@
 <?php
 /**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
+ * Copyright 2017 Adobe
+ * All Rights Reserved.
  */
 declare(strict_types=1);
 
@@ -39,6 +39,8 @@ public function validate(array $rowData, int $rowNumber)
 
         if (!isset($rowData[Sources::COL_QTY])) {
             $errors[] = __('Missing required column "%column"', ['column' => Sources::COL_QTY]);
+        } elseif (!is_numeric($rowData[Sources::COL_QTY])) {
+            $errors[] = __('"%column" contains incorrect value', ['column' => Sources::COL_QTY]);
         }
 
         return $this->validationResultFactory->create(['errors' => $errors]);

InventoryImportExport/Test/Unit/Model/Import/Validator/QtyValidatorTest.php

@@ -0,0 +1,86 @@
+<?php
+/**
+ * Copyright 2024 Adobe
+ * All Rights Reserved.
+ */
+declare(strict_types=1);
+
+namespace Magento\InventoryImportExport\Test\Unit\Model\Import\Validator;
+
+use Magento\Framework\Validation\ValidationResult;
+use Magento\Framework\Validation\ValidationResultFactory;
+use Magento\InventoryImportExport\Model\Import\Sources;
+use Magento\InventoryImportExport\Model\Import\Validator\QtyValidator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+
+class QtyValidatorTest extends TestCase
+{
+    /**
+     * @var MockObject|null
+     */
+    private ?MockObject $validationResultFactory;
+
+    /**
+     * @var QtyValidator|null
+     */
+    private ?QtyValidator $model;
+
+    protected function setUp(): void
+    {
+        parent::setUp();
+        $this->validationResultFactory = $this->createMock(ValidationResultFactory::class);
+        $this->model = new QtyValidator($this->validationResultFactory);
+    }
+
+    #[DataProvider('validateDataProvider')]
+    public function testValidate(array $data, array $errors = []): void
+    {
+        $rowNumber = 1;
+        $result = new ValidationResult([]);
+        $this->validationResultFactory
+            ->expects($this->once())->method('create')
+            ->with(['errors' => $errors])
+            ->willReturn($result);
+        $this->assertSame($result, $this->model->validate($data, $rowNumber));
+    }
+
+    public static function validateDataProvider(): array
+    {
+        return [
+            [
+                [Sources::COL_QTY => 1,],
+            ],
+            [
+                [Sources::COL_QTY => 0,],
+            ],
+            [
+                [Sources::COL_QTY => -1,],
+            ],
+            [
+                [Sources::COL_QTY => 0.1,],
+            ],
+            [
+                [Sources::COL_QTY => '1',],
+            ],
+            [
+                [Sources::COL_QTY => '0',],
+            ],
+            [
+                [Sources::COL_QTY => '-1',],
+            ],
+            [
+                [Sources::COL_QTY => '0.1',],
+            ],
+            [
+                [Sources::COL_QTY => 'abc',],
+                [__('"%column" contains incorrect value', ['column' => Sources::COL_QTY])],
+            ],
+            [
+                ['qty' => 1,],
+                [__('Missing required column "%column"', ['column' => Sources::COL_QTY])],
+            ],
+        ];
+    }
+}

InventoryImportExport/i18n/en_US.csv

@@ -10,3 +10,4 @@
 "Missing required column ""%column""","Missing required column ""%column"""
 "Source code ""%code"" does not exists","Source code ""%code"" does not exists"
 "Row Validator must implement %interface.","Row Validator must implement %interface."
+"""%column"" contains incorrect value","""%column"" contains incorrect value"