Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PHP assert() function from list of forbidden functions #489

Open
oleksii-lisovyi opened this issue Jan 1, 2025 · 1 comment
Open
Labels
enhancement Improvements to existing rules Progress: ready for grooming

Comments

@oleksii-lisovyi
Copy link

Description

AFAIK starting from PHP 8.0 the main security issue of assert() function implementation is removed. Thus given the minimum PHP requirement version for the Coding Standards is 8.1 the function should be removed from the list of the forbidden functions.

Expected behavior

No error The use of function assert() is forbidden is shown when checking the standards on Magento code.

Benefits

The function usage is allowed which provides reducing of boilerplate in code base.

Additional information

I'm not a security expert, so I might be wrong on the topic.

@oleksii-lisovyi oleksii-lisovyi added the enhancement Improvements to existing rules label Jan 1, 2025
Copy link

m2-assistant bot commented Jan 1, 2025

Hi @oleksii-lisovyi. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing rules Progress: ready for grooming
Projects
None yet
Development

No branches or pull requests

1 participant