transit: Make TransitConnector crate-public

Author: felinira

src/transfer/v2.rs

@@ -128,15 +128,25 @@ async fn make_transit(
         };
 
     /* Get a transit connection */
-    let (transit, info) = match connector
-        .connect(
+    let connect_result = if is_leader {
+        connector
+            .leader_connect(
+                is_leader,
+                wormhole.key().derive_transit_key(wormhole.appid()),
+                peer_abilities,
+                Arc::new(their_hints),
+            )
+            .await
+    } else {
+        connector.follower_connect(
             is_leader,
             wormhole.key().derive_transit_key(wormhole.appid()),
             peer_abilities,
             Arc::new(their_hints),
         )
-        .await
-    {
+    };
+
+    let (transit, info) = match connect_result {
         Ok(transit) => transit,
         Err(error) => {
             let error = TransferError::TransitConnect(error);

src/transit.rs

@@ -51,7 +51,7 @@ const PUBLIC_STUN_SERVER: &str = "stun.piegames.de:3478";
     note = "This will be a private type in the future. Open an issue if you require access to protocol intrinsics in the future"
 )]
 #[derive(Debug)]
-pub struct TransitKey;
+pub(crate) struct TransitKey;
 
 #[expect(deprecated)]
 impl KeyPurpose for TransitKey {}
@@ -785,7 +785,7 @@ pub fn log_transit_connection(
     note = "This will be a private type in the future. Open an issue if you require access to protocol intrinsics in the future"
 )]
 #[expect(deprecated)]
-pub async fn init(
+pub(crate) async fn init(
     mut abilities: Abilities,
     peer_abilities: Option<Abilities>,
     relay_hints: Vec<RelayHint>,
@@ -931,7 +931,7 @@ impl MaybeConnectedSocket {
     since = "0.7.0",
     note = "This will be a private type in the future. Open an issue if you require access to protocol intrinsics in the future"
 )]
-pub struct TransitConnector {
+pub(crate) struct TransitConnector {
     /* Only `Some` if direct-tcp-v1 ability has been enabled.
      * The first socket is the port from which we will start connection attempts.
      * For in case the user is behind no firewalls, we must also listen to the second socket.
@@ -954,29 +954,6 @@ impl TransitConnector {
         &self.our_hints
     }
 
-    /**
-     * Forwards to either [`leader_connect`](Self::leader_connect) or [`follower_connect`](Self::follower_connect).
-     *
-     * It usually is better to call the respective functions directly by their name, as it makes
-     * them less easy to confuse (confusion may still happen though). Nevertheless, sometimes it
-     * is desirable to use the same code for both sides and only track the side with a boolean.
-     */
-    pub async fn connect(
-        self,
-        is_leader: bool,
-        transit_key: Key<TransitKey>,
-        their_abilities: Abilities,
-        their_hints: Arc<Hints>,
-    ) -> Result<(Transit, TransitInfo), TransitConnectError> {
-        if is_leader {
-            self.leader_connect(transit_key, their_abilities, their_hints)
-                .await
-        } else {
-            self.follower_connect(transit_key, their_abilities, their_hints)
-                .await
-        }
-    }
-
     /**
      * Connect to the other side, as sender.
      */