New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `waitForPromise` calls to the SessionService methods #2959

Closed

Windvis wants to merge 1 commit into mainmatter:master from Windvis:session-method-test-waiters

Contributor

Windvis commented Mar 26, 2025 •

edited

Loading

I'm not 100% sure this is the correct place to add these waiters, and if this can be tested somehow.

Closes #2272


          Add waitForPromise calls to the SessionService methods

fc63c5d

Contributor Author

Windvis commented Mar 27, 2025

Closing again since I won't have time in the near future to look into why CI is failing.

Windvis closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet