Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guardian/Absolute/VR/Crack 3s upslot not able to handle AG (v1.2.2) #56

Open
PremiumShiny opened this issue Feb 14, 2021 · 2 comments
Open
Labels
bug Something isn't working

Comments

@PremiumShiny
Copy link

PremiumShiny commented Feb 14, 2021

Describe the bug
Upslotting from 3s to 4s using Augment Guidance breaks the assistant.
Guardian Soul
Absolute Glare
Crack V
Veteran's Resolve V

To Reproduce
Steps to reproduce the behavior:

  1. Create new affix.
  2. Select Guardian Soul/Absolute Glare/Crack V/Veteran's Resolve V
  3. Check the "Affix by Upslotting" and "Augment Guidance" boxes
  4. Select GSoul recpie using episode fodders, Crack5 using 3x c4 and VR5 using 3x vr5
  5. "Uh oh..." screen appears

Expected behavior
The formula should pass and allow AG on the base since there should still be 2 free junk slots left in the final affix.

Screenshots
image
Image 1. The formula I want to use.

https://youtu.be/XEMT6JbEVxQ
Video 1. Showing the 3s formula not being able to handle AG.

image
Image 2. 3s upslot w/ AG for 0.8%

image
Image 3. 3s upslot w/o AG for 0.2%

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Google Chrome
  • Version: v1.2.2 (tested on both malulleybovo and Corvous Global versions)

Additional context
I found that it is possible to make if you select GSoul using Receptor as well as either Crack or Vet using only 2 fodders instead of 3 (5 junk total) as well as obviously GSoul using Receptor and Crack and Vet both using only 2 fodders (6 junk total).

I'm not an affix master so wasn't sure if the formula was just not creatable or if it's a bug from the assistant. I could always just use Life's Guidance Lv.2 to give myself an extra 5% or something but just wanted to let you know. I tried punching in the formula in Affix Simulator and it worked both with (2 junk total) and without AG when upslotting.

@malulleybovo
Copy link
Owner

Thank you for reporting. From the video, it is apparent that you have encountered a bug in the Assistant. Granted that you were using an alternate version from a Fork of the Assistant project that is under review, I double checked the above scenario and this bug is also present in the original repository. Since this is related to the inner logic of the Assistant, it might take some time to find out the cause. This issue will be updated when more information is obtained.

@malulleybovo malulleybovo added the bug Something isn't working label Feb 14, 2021
@xRUFUSx
Copy link

xRUFUSx commented May 12, 2021

Just a note about the bug's behavior that may guide troubleshooting - Without "affix by upslotting" checked, the assistant assigns 4 augments to the last fodder piece. If the assistant would attempt to fill available slots from the first instead of the last available slots, perhaps this bug would not occur? Thank you for your valuable work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants