Skip to content

Commit 523e8da

Browse files
committed
Fix comments after dropping python 3.7
1 parent 3f236ac commit 523e8da

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ jobs:
145145
strategy:
146146
fail-fast: false
147147
matrix:
148-
# This uses old arcticdb versions which won't work on python < 3.12
148+
# This uses old arcticdb versions which won't work on python >= 3.12. So we test up to 3.11.
149149
python3: ${{fromJson(vars.LINUX_PYTHON_VERSIONS || '[8, 9, 10, 11]')}}
150150
arcticdb_version: ["oldest", "latest"]
151151
include:
@@ -169,7 +169,7 @@ jobs:
169169
strategy:
170170
fail-fast: false
171171
matrix:
172-
# This uses old arcticdb versions which won't work on python < 3.12
172+
# This uses old arcticdb versions which won't work on python >= 3.12. So we test up to 3.11.
173173
python3: ${{fromJson(vars.WINDOWS_PYTHON_VERSIONS || '[8, 9, 10, 11]')}}
174174
arcticdb_version: ["oldest", "latest"]
175175
include:
@@ -279,7 +279,7 @@ jobs:
279279
strategy:
280280
fail-fast: false
281281
matrix:
282-
# This uses old arcticdb versions which won't work on python < 3.12
282+
# This uses old arcticdb versions which won't work on python >= 3.12. So we test up to 3.11.
283283
python3: ${{fromJson(vars.LINUX_PYTHON_VERSIONS || '[8, 9, 10, 11]')}}
284284
arcticdb_version: ["oldest", "latest"]
285285
include:
@@ -302,7 +302,7 @@ jobs:
302302
strategy:
303303
fail-fast: false
304304
matrix:
305-
# This uses old arcticdb versions which won't work on python < 3.12
305+
# This uses old arcticdb versions which won't work on python >= 3.12. So we test up to 3.11.
306306
python3: ${{fromJson(vars.WINDOWS_PYTHON_VERSIONS || '[8, 9, 10, 11]')}}
307307
arcticdb_version: ["oldest", "latest"]
308308
include:

python/tests/util/mark.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,10 +116,10 @@
116116

117117
FORK_SUPPORTED = pytest.mark.skipif(WINDOWS, reason="Fork not supported on Windows")
118118

119-
## MEMRAY supports linux and macos and python 3.8 and above
119+
## MEMRAY supports linux and macos
120120
MEMRAY_SUPPORTED = (MACOS or LINUX)
121121
MEMRAY_TESTS_MARK = pytest.mark.skipif(
122-
not MEMRAY_SUPPORTED, reason="MEMRAY supports linux and macos and python 3.8 and above"
122+
not MEMRAY_SUPPORTED, reason="MEMRAY supports linux and macos"
123123
)
124124

125125
ZONE_INFO_MARK = pytest.mark.skipif(

0 commit comments

Comments
 (0)