Skip to content

Commit 941594d

Browse files
authored
Fix for flaky test - test_resample_dynamic_schema (#2710)
#### Reference Issues/PRs <!--Example: Fixes #1234. See also #3456.--> #### What does this implement or fix? #### Any other comments? #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing -->
1 parent 4663a6a commit 941594d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

python/arcticdb/util/test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1031,9 +1031,9 @@ def generic_resample_test(
10311031
try:
10321032
assert_resampled_dataframes_are_equal(received, expected, check_dtype=check_dtype)
10331033
except AssertionError:
1034-
if origin == "end_day" and closed == "right":
1034+
if origin in ["end_day", "end"] and closed == "right":
10351035
# Pandas has a bug https://github.com/pandas-dev/pandas/issues/62154
1036-
# When end_day is used with right closed, and the first rows lie on the bucket, Pandas includes them in the
1036+
# When end_day or end is used with right closed, and the first rows lie on the bucket, Pandas includes them in the
10371037
# bucket, which is wrong since closed is right. We remove the first rows from the dataframe and run the
10381038
# resampling again.
10391039

0 commit comments

Comments
 (0)