Skip to content

Commit b2d82c5

Browse files
committed
Fix comments after dropping python 3.7
1 parent 7acd347 commit b2d82c5

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ jobs:
236236
strategy:
237237
fail-fast: false
238238
matrix:
239-
# This uses old arcticdb versions which won't work on python < 3.12
239+
# This uses old arcticdb versions which won't work on python >= 3.12. So we test up to 3.11.
240240
python3: ${{fromJson(inputs.run_full_matrix_of_persistent_tests && '[8, 9, 10, 11]' || '[11]')}}
241241
arcticdb_version: ["oldest", "latest"]
242242
include:
@@ -262,7 +262,7 @@ jobs:
262262
strategy:
263263
fail-fast: false
264264
matrix:
265-
# This uses old arcticdb versions which won't work on python < 3.12
265+
# This uses old arcticdb versions which won't work on python >= 3.12. So we test up to 3.11.
266266
python3: ${{fromJson(inputs.run_full_matrix_of_persistent_tests && '[8, 9, 10, 11]' || '[11]')}}
267267
arcticdb_version: ["oldest", "latest"]
268268
include:
@@ -396,7 +396,7 @@ jobs:
396396
strategy:
397397
fail-fast: false
398398
matrix:
399-
# This uses old arcticdb versions which won't work on python < 3.12
399+
# This uses old arcticdb versions which won't work on python >= 3.12. So we test up to 3.11.
400400
python3: ${{ fromJson(inputs.run_full_matrix_of_persistent_tests && '[8, 9, 10, 11]' || '[11]') }}
401401
arcticdb_version: ["oldest", "latest"]
402402
include:
@@ -421,7 +421,7 @@ jobs:
421421
strategy:
422422
fail-fast: false
423423
matrix:
424-
# This uses old arcticdb versions which won't work on python < 3.12
424+
# This uses old arcticdb versions which won't work on python >= 3.12. So we test up to 3.11.
425425
python3: ${{ fromJson(inputs.run_full_matrix_of_persistent_tests && '[8, 9, 10, 11]' || '[11]') }}
426426
arcticdb_version: ["oldest", "latest"]
427427
include:

python/tests/util/mark.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -226,11 +226,9 @@ def getenv_strip(env_var_name: str, default_value: Optional[str] = None) -> Opti
226226

227227
FORK_SUPPORTED = pytest.mark.skipif(WINDOWS, reason="Fork not supported on Windows")
228228

229-
## MEMRAY supports linux and macos and python 3.8 and above
229+
## MEMRAY supports linux and macos
230230
MEMRAY_SUPPORTED = MACOS or LINUX
231-
MEMRAY_TESTS_MARK = pytest.mark.skipif(
232-
not MEMRAY_SUPPORTED, reason="MEMRAY supports linux and macos and python 3.8 and above"
233-
)
231+
MEMRAY_TESTS_MARK = pytest.mark.skipif(not MEMRAY_SUPPORTED, reason="MEMRAY supports linux and macos")
234232

235233
ZONE_INFO_MARK = pytest.mark.skipif(sys.version_info < (3, 9), reason="zoneinfo module was introduced in Python 3.9")
236234

0 commit comments

Comments
 (0)