Skip to content

Commit a65ab50

Browse files
committed
Stopping Zookeeper on EmbeddedKafka.stop()
Fixes #150
1 parent 890e34c commit a65ab50

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

embedded-kafka/src/main/scala/net/manub/embeddedkafka/EmbeddedKafka.scala

+2-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ object EmbeddedKafka extends EmbeddedKafkaSupport[EmbeddedKafkaConfig] {
7979
val broker =
8080
EmbeddedK(Option(factory), kafkaServer, kafkaLogsDir, actualConfig)
8181

82-
servers :+= broker
82+
servers ++= Seq(broker, factory)
83+
8384
broker
8485
}
8586

embedded-kafka/src/main/scala/net/manub/embeddedkafka/EmbeddedServer.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ case class EmbeddedZ(factory: ServerCnxnFactory, logsDirs: Directory)(
2929
*
3030
* @param clearLogs pass `true` to recursively delete the log directory.
3131
*/
32-
override def stop(clearLogs: Boolean) = {
32+
override def stop(clearLogs: Boolean): Unit = {
3333
factory.shutdown()
3434
if (clearLogs) logsDirs.deleteRecursively()
3535
}

embedded-kafka/src/test/scala/net/manub/embeddedkafka/EmbeddedKafkaObjectSpec.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class EmbeddedKafkaObjectSpec extends EmbeddedKafkaSpecSupport {
3030
}
3131

3232
"start and stop Kafka and Zookeeper on different specified ports using an implicit configuration" in {
33-
implicit val config =
33+
implicit val config: EmbeddedKafkaConfig =
3434
EmbeddedKafkaConfig(kafkaPort = 12345, zooKeeperPort = 54321)
3535
EmbeddedKafka.start()
3636

0 commit comments

Comments
 (0)