Skip to content

Commit ddea227

Browse files
brnkhyabhishektrip
authored andcommitted
fix an issue where vector factory wasn't tracking layer visualizers properly and firing finished event before they all finish (#1350)
1 parent 822106c commit ddea227

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

sdkproject/Assets/Mapbox/Unity/Map/AbstractMapVisualizer.cs

-1
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,6 @@ public virtual void TileStateChanged(UnityTile tile)
186186

187187
if (rasterDone && terrainDone && vectorDone)
188188
{
189-
Debug.Log("Tile Done");
190189
tile.TileState = MeshGeneration.Enums.TilePropertyState.Loaded;
191190
OnTileFinished(tile);
192191

sdkproject/Assets/Mapbox/Unity/MeshGeneration/Factories/VectorTileFactory.cs

+12-2
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ public VectorLayerProperties Properties
5959
#region Public Methods
6060
public void RedrawSubLayer(UnityTile tile, LayerVisualizerBase visualizer)
6161
{
62-
TrackFeatureWithBuilder(tile, visualizer.SubLayerProperties.coreOptions.layerName, visualizer);
6362
CreateFeatureWithBuilder(tile, visualizer.SubLayerProperties.coreOptions.layerName, visualizer);
6463
}
6564

@@ -441,6 +440,18 @@ private void CreateFeatureWithBuilder(UnityTile tile, string layerName, LayerVis
441440
{
442441
if (builder.Active)
443442
{
443+
if (_layerProgress.ContainsKey(tile))
444+
{
445+
_layerProgress[tile].Add(builder);
446+
}
447+
else
448+
{
449+
_layerProgress.Add(tile, new HashSet<LayerVisualizerBase> { builder });
450+
if (!_tilesWaitingProcessing.Contains(tile))
451+
{
452+
_tilesWaitingProcessing.Add(tile);
453+
}
454+
}
444455
if (layerName != "")
445456
{
446457
builder.Create(tile.VectorData.Data.GetLayer(layerName), tile, DecreaseProgressCounter);
@@ -453,7 +464,6 @@ private void CreateFeatureWithBuilder(UnityTile tile, string layerName, LayerVis
453464
}
454465
}
455466

456-
457467
private void DecreaseProgressCounter(UnityTile tile, LayerVisualizerBase builder)
458468
{
459469
if (_layerProgress.ContainsKey(tile))

0 commit comments

Comments
 (0)