Skip to content

Commit e1727ea

Browse files
authored
Merge pull request #1220 from mapbox/revertUriBuilderChanges
revert uribuilder changes from before for safety
2 parents c5a69a0 + 91df88d commit e1727ea

File tree

3 files changed

+35
-11
lines changed

3 files changed

+35
-11
lines changed

sdkproject/Assets/Mapbox/Core/mapbox-sdk-cs/Map/TileResource.cs

+12-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,18 @@ internal static TileResource MakeStyleOptimizedVector(CanonicalTileId id, string
5555

5656
public string GetUrl()
5757
{
58-
return _query;
58+
var uriBuilder = new UriBuilder(_query);
59+
if (uriBuilder.Query != null && uriBuilder.Query.Length > 1)
60+
{
61+
uriBuilder.Query = uriBuilder.Query.Substring(1) + "&" + TelemetryFactory.EventQuery;
62+
}
63+
else
64+
{
65+
uriBuilder.Query = TelemetryFactory.EventQuery;
66+
}
67+
68+
//return uriBuilder.ToString();
69+
return uriBuilder.Uri.ToString();
5970
}
6071
}
6172
}

sdkproject/Assets/Mapbox/Core/mapbox-sdk-cs/Platform/Cache/CachingWebFileSource.cs

+13-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
using Mapbox.Unity.Telemetry;
2-
3-
namespace Mapbox.Platform.Cache
1+
namespace Mapbox.Platform.Cache
42
{
53
using System;
64
using Mapbox.Platform;
@@ -118,6 +116,7 @@ string uri
118116
, string mapId = null
119117
)
120118
{
119+
121120
if (string.IsNullOrEmpty(mapId))
122121
{
123122
throw new Exception("Cannot cache without a map id");
@@ -135,11 +134,20 @@ string uri
135134
}
136135
}
137136

138-
var finalUrl = uri + "?" + TelemetryFactory.EventQuery;
137+
var uriBuilder = new UriBuilder(uri);
139138
if (!string.IsNullOrEmpty(_accessToken))
140139
{
141-
finalUrl += "&access_token=" + _accessToken;
140+
string accessTokenQuery = "access_token=" + _accessToken;
141+
if (uriBuilder.Query != null && uriBuilder.Query.Length > 1)
142+
{
143+
uriBuilder.Query = uriBuilder.Query.Substring(1) + "&" + accessTokenQuery;
144+
}
145+
else
146+
{
147+
uriBuilder.Query = accessTokenQuery;
148+
}
142149
}
150+
string finalUrl = uriBuilder.ToString();
143151

144152
#if MAPBOX_DEBUG_CACHE
145153
string methodName = _className + "." + new System.Diagnostics.StackFrame().GetMethod().Name;

sdkproject/Assets/Mapbox/Core/mapbox-sdk-cs/Platform/FileSource.cs

+10-5
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
// </copyright>
55
//-----------------------------------------------------------------------
66

7-
using Mapbox.Unity.Telemetry;
8-
97
namespace Mapbox.Platform
108
{
119
using Mapbox.Map;
@@ -86,11 +84,18 @@ string url
8684
{
8785
if (!string.IsNullOrEmpty(_accessToken))
8886
{
89-
url = url + "?" + TelemetryFactory.EventQuery;
90-
if (!string.IsNullOrEmpty(_accessToken))
87+
var uriBuilder = new UriBuilder(url);
88+
string accessTokenQuery = "access_token=" + _accessToken;
89+
if (uriBuilder.Query != null && uriBuilder.Query.Length > 1)
90+
{
91+
uriBuilder.Query = uriBuilder.Query.Substring(1) + "&" + accessTokenQuery;
92+
}
93+
else
9194
{
92-
url += "&access_token=" + _accessToken;
95+
uriBuilder.Query = accessTokenQuery;
9396
}
97+
98+
url = uriBuilder.ToString();
9499
}
95100

96101
// TODO:

0 commit comments

Comments
 (0)