chore: replace node-fetch and https-proxy-agent with undici

Author: benmccann

.eslintrc

@@ -26,6 +26,9 @@
       {
       "checkLoops": false
       }
-    ]
+    ],
+    "n/no-unsupported-features/node-builtins": ["error", {
+      "allowExperimental": true
+    }]
   }
 }

lib/install.js

@@ -7,12 +7,12 @@ exports.usage = 'Attempts to install pre-built binary for module';
 const fs = require('fs');
 const path = require('path');
 const log = require('npmlog');
+const { ProxyAgent } = require('undici');
 const existsAsync = fs.exists || path.exists;
 const versioning = require('./util/versioning.js');
 const napi = require('./util/napi.js');
 const makeDir = require('make-dir');
 // for fetching binaries
-const fetch = require('node-fetch');
 const tar = require('tar');
 
 let npgVersion = 'unknown';
@@ -56,12 +56,11 @@ function place_binary(uri, targetDir, opts, callback) {
                     process.env.npm_config_proxy;
   let agent;
   if (proxyUrl) {
-    const ProxyAgent = require('https-proxy-agent');
     agent = new ProxyAgent(proxyUrl);
     log.http('download', 'proxy agent configured using: "%s"', proxyUrl);
   }
 
-  fetch(sanitized, { agent })
+  fetch(sanitized, { dispatcher: agent })
     .then((res) => {
       if (!res.ok) {
         throw new Error(`response status ${res.status} ${res.statusText} on ${sanitized}`);

package-lock.json

@@ -24,13 +24,12 @@
   },
   "dependencies": {
     "detect-libc": "^2.0.0",
-    "https-proxy-agent": "^5.0.0",
     "make-dir": "^3.1.0",
-    "node-fetch": "^2.6.7",
     "nopt": "^7.2.1",
     "npmlog": "^7.0.1",
     "semver": "^7.3.5",
-    "tar": "^7.4.0"
+    "tar": "^7.4.0",
+    "undici": "^6.19.2"
   },
   "devDependencies": {
     "@mapbox/cloudfriend": "^5.1.0",
@@ -40,7 +39,7 @@
     "eslint": "^8.57.0",
     "eslint-plugin-n": "^17.9.0",
     "mock-aws-s3": "^4.0.2",
-    "nock": "^12.0.3",
+    "nock": "^14.0.0-beta.8",
     "node-addon-api": "^4.3.0",
     "nyc": "^15.1.0",
     "tape": "^5.5.2",

package.json

@@ -6,7 +6,7 @@ const { createUnzip } = require('zlib');
 const os = require('os');
 
 const tar = require('tar-fs');
-const Agent = require('https-proxy-agent');
+const { ProxyAgent } = require('undici');
 const fetch = require('node-fetch');
 const { rimraf } = require('rimraf');
 
@@ -44,7 +44,7 @@ test('setup proxy server', (t) => {
   proxy.startServer({ port: proxyPort });
   process.env.https_proxy = process.env.http_proxy = proxyServer;
 
-  options.agent = new Agent(proxyServer);
+  options.dispatcher = new ProxyAgent(proxyServer);
 
   // make sure the download directory deleted then create an empty one
   rimraf(downloadDir).then(() => {