Copy/Pasting List Properties Makes them Permanently Uneditable

[AxiomVerge]

Describe the bug

After making a new List Property on an object (in my case, Rectangle) and filling it with strings, if you copy and paste the list to another object, it pastes the an apparently empty list of the same name. If you try to edit the blank entries, they won't be saved and become blank again as soon as you click on another object and back. If you try to add new entries, they also won't be saved.

In the .tmx file, the mangled list looks like this:

<property name="ParallaxLayers" type="list"> <item type="std::nullptr_t" value=""/> </property

A workaround is to copy and paste within the tmx file instead of in the editor.

Steps to reproduce

1. In an Object Layer, create a new object (Recangle works).
2. Under Custom Properties, click Add Property.
3. Change the type to "list" and give a name.
4. Click Add and choose "string" (other types also have the bug, but I did not try them all)
5. Type some text into the new list entry.
6. Right click on your new list and choose "Copy".
7. Create a second object.
8. Right Click under Custom Properties and Paste.
9. Notice the list entry is blank. Fill it with some text and save the file.
10. Click on another object, then back again. The list entry is empty.
11. Open the .tmx and search for your second object. Notice that the list item is of type "std::nullptr_t".

Expected behavior

I expect it to copy the list and its contents over to the second object.

OS version

Windows 11

Tiled version

1.12.1

[Bails86]

Have started working on this issue and should get it fixed in a few days!

[bjorn]

@Bails86 Alright, thanks! Just note that I want to release 1.12.2 asap and it would be good to have a look at fixing this as well before doing that release, so I will also have a look into this.

[Bails86]

I've been working on it today. I have it working but it is a temporary fix stage at the moment. I followed it to the propertiesToJson where the propertyObject.insert was not converting the list properly, causing it to register the size of the list but not enter its values.

I bypassed the original:
propertyObject.insert(QLatin1String("value"), exportValue.valueName);

so now it is:

for (; it != it_end; ++it) {
    const QString &name = it.key();
    const auto exportValue = context.toExportValue(it.value());

    QJsonObject propertyObject;
    propertyObject.insert(QLatin1String("name"), name);
    propertyObject.insert(QLatin1String("value"), QJsonValue::fromVariant(it.value().toJsonValue())); <---- The change is here
    propertyObject.insert(QLatin1String("type"), exportValue.typeName);
    propertyObject.insert(QLatin1String("propertytype"), exportValue.propertyTypeName);

    json.append(propertyObject);
}