Skip to content

Commit 6b5fda8

Browse files
committed
Bug 1999319 [wpt PR 55961] - [gap-decorations] Fix multicol CrossGap's EdgeIntersection state, a=testonly
Automatic update from web-platform-tests [gap-decorations] Fix multicol CrossGap's EdgeIntersection state Due to some recent changes to the `outset` behavior, we have to now differentiate between `edge` intersections and `interior` intersections which wasn't previously needed for multicol (they were all treated as edge). w3c/csswg-drafts#12603 This CL fixes this and marks the relevant tests as passing, although a change was needed to one of them that was wrong (row gaps/ main gaps in multicol always span from one end of the content to the other, since there are no intersections between row gaps and column gaps). This CL also modifies an existing unittest that with recent changes done to the `column-wrap` feature, it got all twisted and didn't make as much sense anymore (visually). It still tests the same scenario as before (having a spanner and a row gap in the same multicol). It must be noted that depending on some ongoing discussions, we might still want all multicol CrossGaps to be treated as edge intersections, but that is TBD. w3c/csswg-drafts#12784 Bug: 357648037 Change-Id: I95b452ffb89b4117f4855ae9cc1a1c9b00dfdc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7125761 Reviewed-by: Alison Maher <almahermicrosoft.com> Commit-Queue: Javier Contreras <javierconmicrosoft.com> Cr-Commit-Position: refs/heads/main{#1542604} -- wpt-commits: 295c5cef574c15782af987a0efbba0f03872f049 wpt-pr: 55961 UltraBlame original commit: a1a17cb136f36680e883dd456bc5fc94c78d821c
1 parent fc348a5 commit 6b5fda8

File tree

2 files changed

+5
-82
lines changed

2 files changed

+5
-82
lines changed

testing/web-platform/tests/css/css-gaps/multicol/multicol-gap-decorations-023-ref.html

Lines changed: 4 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,10 @@
172172
:
173173
gold
174174
;
175+
width
176+
:
177+
203px
178+
;
175179
}
176180
.
177181
row
@@ -315,62 +319,6 @@
315319
:
316320
0px
317321
;
318-
width
319-
:
320-
61px
321-
;
322-
"
323-
>
324-
<
325-
/
326-
div
327-
>
328-
<
329-
div
330-
class
331-
=
332-
"
333-
row
334-
-
335-
gap
336-
"
337-
style
338-
=
339-
"
340-
left
341-
:
342-
72px
343-
;
344-
width
345-
:
346-
59px
347-
;
348-
"
349-
>
350-
<
351-
/
352-
div
353-
>
354-
<
355-
div
356-
class
357-
=
358-
"
359-
row
360-
-
361-
gap
362-
"
363-
style
364-
=
365-
"
366-
left
367-
:
368-
142px
369-
;
370-
width
371-
:
372-
62px
373-
;
374322
"
375323
>
376324
<

testing/web-platform/tests/css/css-gaps/multicol/multicol-gap-decorations-023.html

Lines changed: 1 addition & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -266,31 +266,6 @@
266266
-
267267
rule
268268
-
269-
interior
270-
-
271-
start
272-
-
273-
outset
274-
:
275-
0
276-
;
277-
row
278-
-
279-
rule
280-
-
281-
interior
282-
-
283-
end
284-
-
285-
outset
286-
:
287-
-
288-
1px
289-
;
290-
row
291-
-
292-
rule
293-
-
294269
edge
295270
-
296271
start
@@ -309,7 +284,7 @@
309284
-
310285
outset
311286
:
312-
2px
287+
1px
313288
;
314289
gap
315290
-

0 commit comments

Comments
 (0)