Commit 6b5fda8
committed
Bug 1999319 [wpt PR 55961] - [gap-decorations] Fix multicol CrossGap's EdgeIntersection state, a=testonly
Automatic update from web-platform-tests
[gap-decorations] Fix multicol CrossGap's EdgeIntersection state
Due to some recent changes to the `outset` behavior, we have to now
differentiate between `edge` intersections and `interior` intersections
which wasn't previously needed for multicol (they were all treated as
edge).
w3c/csswg-drafts#12603
This CL fixes this and marks the relevant tests as passing, although a
change was needed to one of them that was wrong (row gaps/ main gaps in
multicol always span from one end of the content to the other, since
there are no intersections between row gaps and column gaps).
This CL also modifies an existing unittest that with recent changes done
to the `column-wrap` feature, it got all twisted and didn't make as much
sense anymore (visually). It still tests the same scenario as before
(having a spanner and a row gap in the same multicol).
It must be noted that depending on some ongoing discussions, we might
still want all multicol CrossGaps to be treated as edge intersections,
but that is TBD. w3c/csswg-drafts#12784
Bug: 357648037
Change-Id: I95b452ffb89b4117f4855ae9cc1a1c9b00dfdc86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7125761
Reviewed-by: Alison Maher <almahermicrosoft.com>
Commit-Queue: Javier Contreras <javierconmicrosoft.com>
Cr-Commit-Position: refs/heads/main{#1542604}
--
wpt-commits: 295c5cef574c15782af987a0efbba0f03872f049
wpt-pr: 55961
UltraBlame original commit: a1a17cb136f36680e883dd456bc5fc94c78d821c1 parent fc348a5 commit 6b5fda8
File tree
2 files changed
+5
-82
lines changed- testing/web-platform/tests/css/css-gaps/multicol
2 files changed
+5
-82
lines changedLines changed: 4 additions & 56 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
172 | 172 | | |
173 | 173 | | |
174 | 174 | | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
175 | 179 | | |
176 | 180 | | |
177 | 181 | | |
| |||
315 | 319 | | |
316 | 320 | | |
317 | 321 | | |
318 | | - | |
319 | | - | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
328 | | - | |
329 | | - | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | | - | |
334 | | - | |
335 | | - | |
336 | | - | |
337 | | - | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
342 | | - | |
343 | | - | |
344 | | - | |
345 | | - | |
346 | | - | |
347 | | - | |
348 | | - | |
349 | | - | |
350 | | - | |
351 | | - | |
352 | | - | |
353 | | - | |
354 | | - | |
355 | | - | |
356 | | - | |
357 | | - | |
358 | | - | |
359 | | - | |
360 | | - | |
361 | | - | |
362 | | - | |
363 | | - | |
364 | | - | |
365 | | - | |
366 | | - | |
367 | | - | |
368 | | - | |
369 | | - | |
370 | | - | |
371 | | - | |
372 | | - | |
373 | | - | |
374 | 322 | | |
375 | 323 | | |
376 | 324 | | |
| |||
Lines changed: 1 addition & 26 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
266 | 266 | | |
267 | 267 | | |
268 | 268 | | |
269 | | - | |
270 | | - | |
271 | | - | |
272 | | - | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | | - | |
277 | | - | |
278 | | - | |
279 | | - | |
280 | | - | |
281 | | - | |
282 | | - | |
283 | | - | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | | - | |
290 | | - | |
291 | | - | |
292 | | - | |
293 | | - | |
294 | 269 | | |
295 | 270 | | |
296 | 271 | | |
| |||
309 | 284 | | |
310 | 285 | | |
311 | 286 | | |
312 | | - | |
| 287 | + | |
313 | 288 | | |
314 | 289 | | |
315 | 290 | | |
| |||
0 commit comments