|
1 | 1 | # Security Review Notes |
2 | 2 |
|
3 | | -These notes summarize the current dependency audit status for the OSS readiness PR. |
| 3 | +These notes summarize the current dependency audit status after the OSS readiness merge and the `security/npm-audit-review` follow-up. |
4 | 4 |
|
5 | 5 | ## Audit Status |
6 | 6 |
|
7 | | -`npm audit` currently reports unresolved findings: |
| 7 | +`npm audit fix` was run without `--force`. |
8 | 8 |
|
9 | | -- 3 moderate severity findings |
10 | | -- 1 high severity finding |
| 9 | +The non-forced audit fix updated safe transitive dependencies in `package-lock.json`: |
| 10 | + |
| 11 | +- `brace-expansion` from `5.0.5` to `5.0.6` |
| 12 | +- `ws` from `8.20.0` to `8.21.0` |
11 | 13 |
|
12 | | -The findings are in the dependency tree, not in newly added documentation. |
| 14 | +After those safe fixes, `npm audit` still reports unresolved findings: |
13 | 15 |
|
14 | | -## Affected Dependency Category |
| 16 | +- 1 moderate severity finding |
| 17 | +- 1 high severity finding |
15 | 18 |
|
16 | | -The current audit output includes advisories in these categories: |
| 19 | +## Remaining Affected Dependency Categories |
| 20 | + |
| 21 | +The remaining audit output includes advisories in these categories: |
17 | 22 |
|
18 | 23 | - Next.js framework dependency advisories |
19 | | -- PostCSS transitive dependency advisories |
20 | | -- `brace-expansion` transitive dependency advisory |
21 | | -- `ws` transitive dependency advisory |
| 24 | +- PostCSS transitive dependency advisory through Next.js |
22 | 25 |
|
23 | 26 | ## Safe Fix Availability |
24 | 27 |
|
25 | | -The audit output indicates: |
| 28 | +The audit output indicates that the remaining Next.js/PostCSS findings require: |
| 29 | + |
| 30 | +```bash |
| 31 | +npm audit fix --force |
| 32 | +``` |
26 | 33 |
|
27 | | -- `brace-expansion` has a fix available through `npm audit fix`. |
28 | | -- `ws` has a fix available through `npm audit fix`. |
29 | | -- Next.js/PostCSS findings require `npm audit fix --force`, which would install `next@16.2.7` outside the currently stated dependency range. |
| 34 | +That command would install `next@16.2.7`, which is outside the currently stated dependency range. |
30 | 35 |
|
31 | | -## Why Risky Fixes Were Not Forced |
| 36 | +## Why Forced Upgrades Were Not Applied |
32 | 37 |
|
33 | | -This PR is scoped to OSS readiness documentation and small validation-safe fixes. Forced dependency updates can change framework behavior, generated lockfile contents, and build/runtime compatibility. |
| 38 | +Forced dependency updates were intentionally not applied in this branch. |
34 | 39 |
|
35 | | -Because this repository uses Next.js 16 and the project-specific instructions warn that this version has breaking changes and requires care, forced framework upgrades should be reviewed in a dedicated dependency PR. |
| 40 | +This repository uses Next.js 16, and the project instructions note that this version can have breaking API, convention, and file-structure changes. A framework update should be reviewed separately with release notes, local usage checks, and focused runtime validation. |
36 | 41 |
|
37 | 42 | ## Recommended Next Action |
38 | 43 |
|
39 | | -Open a separate dependency/security PR to: |
| 44 | +Open a dedicated Next.js security update PR to: |
40 | 45 |
|
41 | | -- run `npm audit` again; |
42 | | -- try `npm audit fix` without force; |
43 | | -- evaluate the required Next.js update separately; |
44 | | -- run lint and build after dependency changes; |
45 | | -- test the auth, dashboard, brainstorming, preview, and export flows; |
| 46 | +- review the relevant Next.js release notes and advisories; |
| 47 | +- update Next.js within an intentional version range; |
| 48 | +- run lint and build after the framework update; |
| 49 | +- smoke test authentication, dashboard, project creation, brainstorming, preview, export, and protected-route behavior; |
46 | 50 | - document any remaining advisories or accepted risk. |
0 commit comments