move istioctl out of pilot subdirectory (istio#3820)

Automatic merge from submit-queue.

move istioctl out of pilot subdirectory

istioctl is cli for all of Istio, not solely Pilot. Move istioctl to
the top-level in istio/istio so that code reflects reality. This will
also make it easier to manage codeowners for cli specific issues
unrelated to Pilot and networking.

Risk: Hopefully none. `istioctl` output binary location is unchanged. This is a non-functional change that is mostly limited to moving files around, fixing imports, and the Makefile paths.

_note_: reviews/reviewers-istio-istioctl still needs to be created.

Author: ayj

CODEOWNERS

@@ -14,6 +14,7 @@
 /tools/     @costinm @ldemailly
 /pkg/       @istio/reviewers-istio-pkg
 /tests/     @istio/reviewers-istio-tests
+/istioctl/  @istio/reviewers-istio-istioctl
 
 # Do not enable this. Seems to cause the parsers to fail and not trigger auto review requests
 #/.circleci/ @istio/reviewers-istio-circleci

Makefile

@@ -297,8 +297,8 @@ lint: buildcache
 # Params: OUT VERSION_PKG SRC
 
 PILOT_GO_BINS:=${ISTIO_OUT}/pilot-discovery ${ISTIO_OUT}/pilot-agent \
-               ${ISTIO_OUT}/istioctl ${ISTIO_OUT}/sidecar-injector
-PILOT_GO_BINS_SHORT:=pilot-discovery pilot-agent istioctl sidecar-injector
+               ${ISTIO_OUT}/sidecar-injector
+PILOT_GO_BINS_SHORT:=pilot-discovery pilot-agent sidecar-injector
 define pilotbuild
 $(1):
 	bin/gobuild.sh ${ISTIO_OUT}/$(1) istio.io/istio/pkg/version ./pilot/cmd/$(1)
@@ -308,13 +308,17 @@ ${ISTIO_OUT}/$(1):
 endef
 $(foreach ITEM,$(PILOT_GO_BINS_SHORT),$(eval $(call pilotbuild,$(ITEM))))
 
+.PHONY: istioctl
+istioctl:
+	bin/gobuild.sh ${ISTIO_OUT}/istioctl istio.io/istio/pkg/version ./istioctl
+
 # Non-static istioctls. These are typically a build artifact.
 ${ISTIO_OUT}/istioctl-linux: depend
-	STATIC=0 GOOS=linux   bin/gobuild.sh $@ istio.io/istio/pkg/version ./pilot/cmd/istioctl
+	STATIC=0 GOOS=linux   bin/gobuild.sh $@ istio.io/istio/pkg/version ./istioctl
 ${ISTIO_OUT}/istioctl-osx: depend
-	STATIC=0 GOOS=darwin  bin/gobuild.sh $@ istio.io/istio/pkg/version ./pilot/cmd/istioctl
+	STATIC=0 GOOS=darwin  bin/gobuild.sh $@ istio.io/istio/pkg/version ./istioctl
 ${ISTIO_OUT}/istioctl-win.exe: depend
-	STATIC=0 GOOS=windows bin/gobuild.sh $@ istio.io/istio/pkg/version ./pilot/cmd/istioctl
+	STATIC=0 GOOS=windows bin/gobuild.sh $@ istio.io/istio/pkg/version ./istioctl
 
 MIXER_GO_BINS:=${ISTIO_OUT}/mixs ${ISTIO_OUT}/mixc
 mixc:
@@ -336,7 +340,7 @@ $(SECURITY_GO_BINS):
 	bin/gobuild.sh $@ istio.io/istio/pkg/version ./security/cmd/$(@F)
 
 .PHONY: build
-build: depend $(PILOT_GO_BINS_SHORT) mixc mixs node_agent istio_ca multicluster_ca
+build: depend $(PILOT_GO_BINS_SHORT) mixc mixs node_agent istio_ca multicluster_ca istioctl
 
 # The following are convenience aliases for most of the go targets
 # The first block is for aliases that are the same as the actual binary,
@@ -390,7 +394,7 @@ ${ISTIO_OUT}/archive: istioctl-all LICENSE README.md istio.VERSION install/updat
 # Used for debugging istioctl during dev work
 .PHONY: istioctl-install
 istioctl-install:
-	go install istio.io/istio/pilot/cmd/istioctl
+	go install istio.io/istio/istioctl
 
 #-----------------------------------------------------------------------------
 # Target: test

istioctl/OWNERS

@@ -0,0 +1,10 @@
+reviewers:
+  - ayj
+  - jmuk
+  - liamawhite
+  - nmittler
+approvers:
+  - ayj
+  - jmuk
+  - liamawhite
+  - nmittler

istioctl/codecov.requirement

@@ -0,0 +1,6 @@
+#Coverage data from SHA:70952e93c04c1d855aa65e72e24199b0c99413a1
+#If the requirement is not set below, it must satisfy default requirement.
+Default:20
+#Package requirement
+#Package name, coverage requirement, actually coverage at specific SHA
+istio.io/istio/istioctl:0 [0]

pilot/cmd/istioctl/config.go renamed to istioctl/config.go

@@ -40,8 +40,8 @@ import (
 	"github.com/spf13/cobra/doc"
 	"k8s.io/client-go/util/homedir"
 
+	"istio.io/istio/istioctl/gendeployment"
 	"istio.io/istio/pilot/cmd"
-	"istio.io/istio/pilot/cmd/istioctl/gendeployment"
 	"istio.io/istio/pilot/pkg/config/kube/crd"
 	"istio.io/istio/pilot/pkg/model"
 	"istio.io/istio/pilot/pkg/serviceregistry/kube"

pilot/cmd/istioctl/deregister.go renamed to istioctl/deregister.go

@@ -4,7 +4,6 @@ Default:20
 #Package requirement
 #Package name, coverage requirement, actually coverage at specific SHA
 istio.io/istio/pilot/cmd:0 [0]
-istio.io/istio/pilot/cmd/istioctl:0 [0]
 istio.io/istio/pilot/cmd/pilot-agent:0 [0]
 istio.io/istio/pilot/cmd/pilot-discovery:0 [0]
 istio.io/istio/pilot/cmd/sidecar-injector:0 [0]