Skip to content

RoundMVPAnnouncement not fired #584

Closed
@maruo34

Description

@maruo34

Describe the bug
RoundMVPAnnouncement not fired never

To Reproduce
Download link to an affected demo: faceit

Code:

	parser.RegisterEventHandler(func(e events.RoundMVPAnnouncement) {
		defer func() {
			if r := recover(); r != nil {
				log.Printf("Panic RoundMVPAnnouncement event: %v", r)
			}
		}()

		log.Printf("MVP: %s", e.Player.Name)

		if player := e.Player; player != nil {
			stats := getOrCreatePlayerStats(playerStats, player.SteamID64)
			stats.mvps++
		}
	})

Expected behavior
I found another way to get mpv, but it's strange why it doesn't work in this event

	parser.RegisterEventHandler(func(e events.FrameDone) {
		for _, pl := range parser.GameState().Participants().All() {
			stats := getOrCreatePlayerStats(playerStats, pl.SteamID64)
			stats.mvps = pl.MVPs()
			stats.rank = pl.Rank()
			stats.RankType = pl.RankType()
		}
	}

Library version
v4.3.3

also I don't quite understand this is either a problem of faceit or the library, most likely faceit. The number of kills and deaths of assists will not match in the summary of the faceit match. I noticed this when I played

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions