Fix null disposal bug in all samples (microsoft#124)

Description of changes

Fixes a bug where all sample extensions (except for notepad and weather-webview) were failing to properly dispose of webview panel resources when closed.

Author: hawkticehurst

default/component-gallery/src/panels/ComponentGalleryPanel.ts

@@ -39,7 +39,7 @@ export class ComponentGalleryPanel {
 
     // Set an event listener to listen for when the panel is disposed (i.e. when the user closes
     // the panel or when the panel is closed programmatically)
-    this._panel.onDidDispose(this.dispose, null, this._disposables);
+    this._panel.onDidDispose(() => this.dispose(), null, this._disposables);
 
     // Set the HTML content for the webview panel
     this._panel.webview.html = this._getWebviewContent(this._panel.webview, extensionUri);

default/hello-world/src/panels/HelloWorldPanel.ts

@@ -27,7 +27,7 @@ export class HelloWorldPanel {
 
     // Set an event listener to listen for when the panel is disposed (i.e. when the user closes
     // the panel or when the panel is closed programmatically)
-    this._panel.onDidDispose(this.dispose, null, this._disposables);
+    this._panel.onDidDispose(() => this.dispose(), null, this._disposables);
 
     // Set the HTML content for the webview panel
     this._panel.webview.html = this._getWebviewContent(this._panel.webview, extensionUri);

frameworks/hello-world-angular/package-lock.json

@@ -27,7 +27,7 @@ export class HelloWorldPanel {
 
     // Set an event listener to listen for when the panel is disposed (i.e. when the user closes
     // the panel or when the panel is closed programmatically)
-    this._panel.onDidDispose(this.dispose, null, this._disposables);
+    this._panel.onDidDispose(() => this.dispose(), null, this._disposables);
 
     // Set the HTML content for the webview panel
     this._panel.webview.html = this._getWebviewContent(this._panel.webview, extensionUri);

frameworks/hello-world-angular/src/panels/HelloWorldPanel.ts

@@ -27,7 +27,7 @@ export class HelloWorldPanel {
 
     // Set an event listener to listen for when the panel is disposed (i.e. when the user closes
     // the panel or when the panel is closed programmatically)
-    this._panel.onDidDispose(this.dispose, null, this._disposables);
+    this._panel.onDidDispose(() => this.dispose(), null, this._disposables);
 
     // Set the HTML content for the webview panel
     this._panel.webview.html = this._getWebviewContent(this._panel.webview, extensionUri);

frameworks/hello-world-react-cra/package-lock.json

@@ -27,7 +27,7 @@ export class HelloWorldPanel {
 
     // Set an event listener to listen for when the panel is disposed (i.e. when the user closes
     // the panel or when the panel is closed programmatically)
-    this._panel.onDidDispose(this.dispose, null, this._disposables);
+    this._panel.onDidDispose(() => this.dispose(), null, this._disposables);
 
     // Set the HTML content for the webview panel
     this._panel.webview.html = this._getWebviewContent(this._panel.webview, extensionUri);

frameworks/hello-world-react-cra/src/panels/HelloWorldPanel.ts

@@ -27,7 +27,7 @@ export class HelloWorldPanel {
 
     // Set an event listener to listen for when the panel is disposed (i.e. when the user closes
     // the panel or when the panel is closed programmatically)
-    this._panel.onDidDispose(this.dispose, null, this._disposables);
+    this._panel.onDidDispose(() => this.dispose(), null, this._disposables);
 
     // Set the HTML content for the webview panel
     this._panel.webview.html = this._getWebviewContent(this._panel.webview, extensionUri);

frameworks/hello-world-react-vite/package-lock.json

@@ -27,7 +27,7 @@ export class HelloWorldPanel {
 
     // Set an event listener to listen for when the panel is disposed (i.e. when the user closes
     // the panel or when the panel is closed programmatically)
-    this._panel.onDidDispose(this.dispose, null, this._disposables);
+    this._panel.onDidDispose(() => this.dispose(), null, this._disposables);
 
     // Set the HTML content for the webview panel
     this._panel.webview.html = this._getWebviewContent(this._panel.webview, extensionUri);

frameworks/hello-world-react-vite/src/panels/HelloWorldPanel.ts

@@ -27,7 +27,7 @@ export class HelloWorldPanel {
 
     // Set an event listener to listen for when the panel is disposed (i.e. when the user closes
     // the panel or when the panel is closed programmatically)
-    this._panel.onDidDispose(this.dispose, null, this._disposables);
+    this._panel.onDidDispose(() => this.dispose(), null, this._disposables);
 
     // Set the HTML content for the webview panel
     this._panel.webview.html = this._getWebviewContent(this._panel.webview, extensionUri);