Add CI

Author: marselester

.github/workflows/ci.yml

@@ -0,0 +1,21 @@
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v3
+        with:
+          go-version: ^1.20
+      - uses: golangci/golangci-lint-action@v3
+        name: golangci-lint
+        with:
+          version: v1.51.2
+      - run: go test -count=1 -v ./...

.golangci.yml

@@ -0,0 +1,5 @@
+issues:
+  exclude-rules:
+    - path: _test\.go
+      linters:
+        - errcheck

decoder.go

@@ -158,7 +158,7 @@ func readN(src io.Reader, buf *bytes.Buffer, n int) ([]byte, error) {
 		return nil, err
 	}
 	if k != n {
-		k, err = src.Read(b[k:])
+		_, err = src.Read(b[k:])
 	}
 
 	return b, err

encoder.go

@@ -75,7 +75,7 @@ func (e *encoder) Uint32(u uint32) {
 // This is useful when overwriting a header field such as FieldsLen
 // because it is not known in advance.
 func (e *encoder) Uint32At(u, offset uint32) error {
-	if offset < 0 || int(offset) >= e.dst.Len() {
+	if int(offset) >= e.dst.Len() {
 		return fmt.Errorf("offset is out of range: %d/%d", offset, e.dst.Len())
 	}
 

encoder_test.go

@@ -23,7 +23,7 @@ func TestEscapeBusLabel(t *testing.T) {
 		buf.Reset()
 
 		escapeBusLabel(name, buf)
-		got := string(buf.Bytes())
+		got := buf.String()
 		if want != got {
 			t.Errorf("expected %q got %q", want, got)
 		}

header.go

@@ -125,7 +125,7 @@ func decodeHeader(dec *decoder, conv *stringConverter, h *header, skipFields boo
 	// A caller might already know the signature from the spec
 	// and choose not to decode the fields as an optimization.
 	if skipFields {
-		if b, err = dec.ReadN(h.FieldsLen); err != nil {
+		if _, err = dec.ReadN(h.FieldsLen); err != nil {
 			return fmt.Errorf("message header: %w", err)
 		}
 	} else {