Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Catalog] icon is not square #4617

Closed
manabu-nakamura opened this issue Feb 21, 2025 · 3 comments · May be fixed by #4618
Closed

[Catalog] icon is not square #4617

manabu-nakamura opened this issue Feb 21, 2025 · 3 comments · May be fixed by #4618
Assignees
@imhappi @kendrickumstattd
Labels
bug Issue: Catalog

Comments

@manabu-nakamura
Copy link
Contributor

Description: The icon is not square.
Image
https://github.com/material-components/material-components-android/blob/master/catalog/java/io/material/catalog/dockedtoolbar/res/layout/cat_docked_toolbar_content.xml:

<Button
  android:id="@+id/docked_toolbar_tab_button"
  android:layout_width="48dp"
  android:layout_height="48dp"
  ...

<Button
  android:id="@+id/docked_toolbar_button_overflow_button"
  android:layout_width="40dp"					<-
  android:layout_height="48dp"
  ...

Expected behavior: The icon is square.
Image
https://github.com/material-components/material-components-android/blob/master/catalog/java/io/material/catalog/dockedtoolbar/res/layout/cat_docked_toolbar_content.xml:

<Button
  android:id="@+id/docked_toolbar_tab_button"
  android:layout_width="48dp"
  android:layout_height="48dp"
  ...

<Button
  android:id="@+id/docked_toolbar_button_overflow_button"
  android:layout_width="48dp"					<-
  android:layout_height="48dp"
  ...

Android API version: 35

Material Library version: a82391a

Device: Android Emulator 35.3.12
@manabu-nakamura manabu-nakamura mentioned this issue Feb 21, 2025
Open
@kendrickumstattd kendrickumstattd self-assigned this Feb 21, 2025
@kendrickumstattd
Copy link
Contributor

Thanks for filing this issue. Touched base with the team -- our mocks specify 40dp x 48dp for the overflow icon. The overflow icon is special in bypassing the min touch target due to being at the edge of the screen.

@michael-winkler
Copy link
Contributor

michael-winkler commented Feb 27, 2025 •
edited
Loading

@kendrickumstattd
But as you can see in the attached screenshots you will notice that the current one is not correct.
Just look at the ripple.

Image

So I think @manabu-nakamura is correct..

Image

At least center it...

@manabu-nakamura
Copy link
Contributor Author

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imhappi imhappi

@kendrickumstattd kendrickumstattd

Labels
bug Issue: Catalog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Catalog] icon is square manabu-nakamura/material-components-android
5 participants
@drchen @imhappi @kendrickumstattd @michael-winkler @manabu-nakamura