Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to reattribute provider with ./console usercountry:attribute #44

Open
uschindler opened this issue Apr 20, 2023 · 2 comments
Open

Comments

@uschindler
Copy link

After installing the provider plugin and the ISP provider databases I assumed that you can also use php ./console usercountry:attribute to update the location_provider database field. This does not work, after running the command the historical log data was not updated.

When looking at the code, the class VisitorGeolocator.php in the UserCountry plugin does not even call the provider plugin to update the data. Actually the geolocator data is directly populated by the VisitorGeolocator without going through the abstractions, it just uses a map which fields in the log entry to update. location_provider is not part of this list of fields to update.

I am not sure how to fix this in the current architecture, because the extra field in the Provider plugin is unknown to UserCountry plugin, so just hacking it into the script won't work.

Is there any way to run the Geolocator in the same way like for UserCountry?

@uschindler
Copy link
Author

I wonder why this needs to be a separate plugin, can the location_provider database field not be populated by the core module from the beginning?

@AltamashShaikh
Copy link
Contributor

@uschindler Currently there is no such option available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants