-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to new-style hook wrappers #216
Comments
Actually I didn't really upgrade to new style. I simply copy-pasted the suggested workaround by pytest dev, so maybe you should re-open this issue. I apologize for any inconvenience caused. |
Yes, I realised that, but I think how you fixed it is better. The pluggy documentation now recommends using To add the new-style hook wrappers we'd need to do version checks on |
Pluggy 1.4.0 (just released) now warns about old-style hook wrappers (xref #221). This breaks any CI that treats warnings as errors. |
Pytest 8 will use the new-style hook wrappers so we should add a version check to update the decorator for our
pytest_runtest_call
hooks.See also: pytest-dev/pytest#11714
Also re-enable the pytestdev test environment.
The text was updated successfully, but these errors were encountered: