Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check usage of chromedp #107

Open
kegsay opened this issue Jul 5, 2024 · 0 comments
Open

Check usage of chromedp #107

kegsay opened this issue Jul 5, 2024 · 0 comments

Comments

@kegsay
Copy link
Member

kegsay commented Jul 5, 2024

I think each time we make a new JS client we're making a new browser, which is A) slow and B) prone to flakiness due to WS timeout errors. We should instead make them as new tabs, given each client is on a random high numbered port.

kegsay added a commit that referenced this issue Jul 5, 2024
Fixes #107 and should be faster to run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant