feat: fix precommit

Author: matteing

.mise.toml

@@ -109,3 +109,21 @@ run = "bash scripts/release.sh"
 description = "Start opal-server with Erlang distribution"
 dir = "opal"
 run = "elixir --sname opal -S mix run --no-halt"
+
+
+# ── CI Preflight ─────────────────────────────────────────────
+
+[tasks."codegen:check"]
+description = "Verify codegen is up-to-date"
+dir = "opal"
+run = "mix run ../scripts/codegen_ts.exs --check"
+
+[tasks.precommit]
+description = "Run everything CI checks: deps, codegen, lint, build, test"
+depends = ["deps"]
+run = [
+  "mise run codegen:check",
+  "mise run lint",
+  "mise run build",
+  "mise run test",
+]

cli/src/sdk/cli-history.ts

@@ -29,8 +29,8 @@ function historyPath(): string {
 function readRaw(): Record<string, unknown> {
   try {
     const data = readFileSync(historyPath(), "utf-8");
-    const parsed = JSON.parse(data);
-    return typeof parsed === "object" && parsed !== null ? parsed : {};
+    const parsed: unknown = JSON.parse(data);
+    return typeof parsed === "object" && parsed !== null ? (parsed as Record<string, unknown>) : {};
   } catch {
     return {};
   }
@@ -51,8 +51,11 @@ export function readHistory(): HistoryEntry[] {
 
   if (!Array.isArray(history)) return [];
   return history.filter(
-    (e): e is HistoryEntry =>
-      typeof e === "object" && e !== null && typeof e.text === "string" && typeof e.timestamp === "string",
+    (e: unknown): e is HistoryEntry =>
+      typeof e === "object" &&
+      e !== null &&
+      typeof (e as HistoryEntry).text === "string" &&
+      typeof (e as HistoryEntry).timestamp === "string",
   );
 }
 

cli/src/sdk/cli-state.ts

@@ -44,8 +44,8 @@ function statePath(): string {
 function readRaw(): StoredState {
   try {
     const data = readFileSync(statePath(), "utf-8");
-    const parsed = JSON.parse(data);
-    return typeof parsed === "object" && parsed !== null ? parsed : {};
+    const parsed: unknown = JSON.parse(data);
+    return typeof parsed === "object" && parsed !== null ? (parsed as StoredState) : {};
   } catch {
     return {};
   }
@@ -65,9 +65,7 @@ export function readCliState(): CliState {
     lastModel: raw.last_model ?? null,
     preferences: {
       ...DEFAULT_PREFERENCES,
-      ...(typeof raw.preferences === "object" && raw.preferences !== null
-        ? (raw.preferences as Record<string, unknown>)
-        : {}),
+      ...(typeof raw.preferences === "object" && raw.preferences !== null ? raw.preferences : {}),
     },
     version: VERSION,
   };

cli/src/state/cli.ts

@@ -36,7 +36,10 @@ export interface CliStateSlice {
   /** Load CLI state and command history from local files. */
   loadCliState: () => void;
   /** Update CLI state to local files. */
-  updateCliState: (updates: { lastModel?: Record<string, unknown> | null; preferences?: Record<string, unknown> }) => void;
+  updateCliState: (updates: {
+    lastModel?: Record<string, unknown> | null;
+    preferences?: Record<string, unknown>;
+  }) => void;
   /** Add a command to history (persisted to disk). */
   addToHistory: (command: string) => void;
 

cli/src/views/opal-view.tsx

@@ -1,5 +1,5 @@
 import React, { type FC } from "react";
-import { Box } from "ink";
+import { Box, Static } from "ink";
 import { Welcome } from "../components/welcome.js";
 import { useOpalStore } from "../state/index.js";
 import { selectFocusedAgent } from "../state/selectors.js";
@@ -38,13 +38,27 @@ export const OpalView: FC = () => {
 
   return (
     <Box flexDirection="column">
-      <Welcome
-        dimmed={hasEntries}
-        workingDir={workingDir}
-        contextFiles={contextFiles}
-        skills={skills}
-        distributionNode={distributionNode}
-      />
+      {hasEntries ? (
+        <Static items={["welcome"] as const} style={{ width: "100%" }}>
+          {() => (
+            <Welcome
+              key="welcome"
+              dimmed
+              workingDir={workingDir}
+              contextFiles={contextFiles}
+              skills={skills}
+              distributionNode={distributionNode}
+            />
+          )}
+        </Static>
+      ) : (
+        <Welcome
+          workingDir={workingDir}
+          contextFiles={contextFiles}
+          skills={skills}
+          distributionNode={distributionNode}
+        />
+      )}
       <Timeline />
       {debugVisible && <DebugPanel />}
       <QueuedMessages messages={queuedMessages} />

opal/lib/opal/application.ex

@@ -7,6 +7,8 @@ defmodule Opal.Application do
 
   @impl true
   def start(_type, _args) do
+    setup_file_logger()
+
     children = [
       {Registry, keys: :unique, name: Opal.Registry},
       {Registry, keys: :duplicate, name: Opal.Events.Registry},
@@ -79,6 +81,36 @@ defmodule Opal.Application do
     |> String.to_atom()
   end
 
+  defp setup_file_logger do
+    data_dir =
+      Application.get_env(:opal, :data_dir) ||
+        Opal.Config.default_data_dir()
+
+    logs_dir = Path.join(Path.expand(data_dir), "logs")
+    log_file = Path.join(logs_dir, "server.log")
+
+    with :ok <- File.mkdir_p(logs_dir),
+         :ok <-
+           :logger.add_handler(:file_log, :logger_std_h, %{
+             config: %{
+               file: String.to_charlist(log_file),
+               max_no_bytes: 5_000_000,
+               max_no_files: 3
+             },
+             formatter:
+               {:logger_formatter,
+                %{
+                  single_line: true,
+                  template: [:time, " [", :level, "] ", :msg, "\n"]
+                }}
+           }) do
+      :ok
+    else
+      {:error, reason} ->
+        Logger.warning("Could not set up file logging: #{inspect(reason)}")
+    end
+  end
+
   defp distribution_cookie do
     case Application.get_env(:opal, :distribution_cookie, :random) do
       :random -> generate_cookie()