Refactor error package (#804)

* refactor errors package

* use refactored errors

* refactor log entry

* Update logs.go

* refactor errors

* fix doc logo

* fix stringify error

* update github actions

* Update build.yml

* Update build.yml

* fix test

* fix wrapping format

Author: maxence-charriere

.github/workflows/build.yml

@@ -8,11 +8,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Setup Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
         with:
           go-version: "1.18"
       - name: Checkout Code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
       - name: Vet
         run: go vet ./...
 
@@ -21,24 +21,24 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Setup Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
         with:
           go-version: "1.18"
       - name: Checkout Code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
       - name: Run Unit Tests
-        run: go test -v -race ./...
+        run: go test -race ./...
 
   client:
     name: WebAssembly Unit Tests
     runs-on: ubuntu-latest
     steps:
       - name: Setup Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
         with:
           go-version: "1.18"
       - name: Checkout Code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
       - name: Install WASM Browser Test
         run: |
           go install github.com/agnivade/wasmbrowsertest@latest

docs/icon.png

@@ -31,7 +31,7 @@ func (p *homePage) initPage(ctx app.Context) {
 func (p *homePage) Render() app.UI {
 	return newPage().
 		Title("go-app").
-		Icon("https://storage.googleapis.com/murlok-github/icon-192.png").
+		Icon("/web/icon.png").
 		Index(
 			newIndexLink().Title("What is go-app?"),
 			newIndexLink().Title("Updates"),

docs/src/home-page.go

@@ -20,26 +20,26 @@ func get(ctx app.Context, path string) ([]byte, error) {
 	req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
 	if err != nil {
 		return nil, errors.New("creating request failed").
-			Tag("path", path).
+			WithTag("path", path).
 			Wrap(err)
 	}
 
 	res, err := http.DefaultClient.Do(req)
 	if err != nil {
 		return nil, errors.New("getting document failed").
-			Tag("path", path).
+			WithTag("path", path).
 			Wrap(err)
 	}
 	defer res.Body.Close()
 
 	if res.StatusCode >= 400 {
-		return nil, errors.New(res.Status).Tag("path", path)
+		return nil, errors.New(res.Status).WithTag("path", path)
 	}
 
 	b, err := ioutil.ReadAll(res.Body)
 	if err != nil {
 		return nil, errors.New("reading document failed").
-			Tag("path", path).
+			WithTag("path", path).
 			Wrap(err)
 	}
 	return b, nil

docs/src/http.go

@@ -103,6 +103,9 @@ func main() {
 		Description: defaultDescription,
 		Author:      "Maxence Charriere",
 		Image:       "https://go-app.dev/web/images/go-app.png",
+		Icon: app.Icon{
+			Default: "/web/icon.png",
+		},
 		Keywords: []string{
 			"go-app",
 			"go",
@@ -158,8 +161,8 @@ func main() {
 
 func runLocal(ctx context.Context, h *app.Handler, opts localOptions) {
 	app.Log(logs.New("starting go-app documentation service").
-		Tag("port", opts.Port).
-		Tag("version", h.Version),
+		WithTag("port", opts.Port).
+		WithTag("version", h.Version),
 	)
 
 	h.Env = app.Environment{

docs/src/main.go

@@ -13,7 +13,7 @@ func handleGetMarkdown(ctx app.Context, a app.Action) {
 	path := a.Tags.Get("path")
 	if path == "" {
 		app.Log(errors.New("getting markdown failed").
-			Tag("reason", "empty path"))
+			WithTag("reason", "empty path"))
 		return
 	}
 	state := markdownState(path)

docs/src/markdown.go

@@ -82,7 +82,7 @@ func getHTML(n *html.Node, class string) (string, error) {
 	section, err := findHTMLNode(n, class)
 	if err != nil {
 		return "", errors.New("finding html node failed").
-			Tag("target", class).
+			WithTag("target", class).
 			Wrap(err)
 	}
 
@@ -91,7 +91,7 @@ func getHTML(n *html.Node, class string) (string, error) {
 	var b bytes.Buffer
 	if err := html.Render(&b, section); err != nil {
 		return "", errors.New("rendering html failed").
-			Tag("target", class).
+			WithTag("target", class).
 			Wrap(err)
 	}
 	return b.String(), nil