Skip to content

Commit f5e53a9

Browse files
authored
fix: fixes feedback method name (#11)
### TL;DR Renamed `Feedback` method to `SetFeedback` in the Session struct. ### What changed? Changed the method name from `Feedback` to `SetFeedback` in the `Session` struct to better reflect that this method is setting feedback rather than retrieving it. The implementation remains the same, still calling `s.commit("add-feedback", f)`. ### How to test? 1. Update any code that calls `session.Feedback()` to use `session.SetFeedback()` instead 2. Verify that feedback functionality continues to work as expected 3. Run existing tests to ensure they pass with the renamed method ### Why make this change? The new name `SetFeedback` more clearly communicates the method's purpose as a setter rather than a getter. This improves code readability and follows better naming conventions for methods that modify state.
2 parents 9b821d8 + a679b55 commit f5e53a9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

logging/session.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ func newSession(c *SessionConfig, w *writer) *Session {
2424
return s
2525
}
2626

27-
func (s *Session) Feedback(f *Feedback) {
27+
func (s *Session) SetFeedback(f *Feedback) {
2828
s.commit("add-feedback", f)
2929
}
3030

0 commit comments

Comments
 (0)