You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
### TL;DR
Fix generation error handling and add documentation to trace.go
### What changed?
- Fixed the `SetError` method in `Generation` to use "result" instead of "update" event type and properly structure the error data
- Added automatic call to `End()` after setting an error in a generation
- Updated `SetGenerationError` in `Logger` to match the same pattern and end the generation after setting an error
- Added documentation comments to all functions and types in trace.go
### How to test?
1. Verify that error handling in generations works correctly by triggering an error condition
2. Confirm that generations are properly ended after an error is set
3. Check that the error data is correctly structured in the logs
### Why make this change?
This change ensures consistent error handling in generations and properly ends generations after errors occur, preventing hanging or incomplete generation records. The added documentation in trace.go improves code readability and helps developers understand the purpose of each component in the tracing system.
0 commit comments