Fixed the tests

Author: JostCrow

djadyen/management/commands/adyen_maintenance.py

@@ -49,3 +49,7 @@ def handle(self, *args, **options):
             ):
                 obj.status = Status.Error
                 obj.save()
+
+        # Close 5 day old notifications
+        for notification in AdyenNotification.objects.filter(is_processed=False, created_at__lte=five_days_ago):
+            notification.mark_processed()

tests/app/models.py

@@ -1,4 +1,5 @@
 from django.db import models
+
 from djadyen.models import AdyenOrder
 
 
@@ -9,7 +10,8 @@ def get_price_in_cents(self):
         return 5000
 
     def process_notification(self, notification):
-        super(Order, self).process_notification(notification)
+        super().process_notification(notification)
+
         if notification.is_authorised():
             self.paid = True
             self.save()

tests/tests/test_management_command.py

@@ -1,5 +1,5 @@
 import json
-from datetime import datetime
+from datetime import datetime, timedelta
 from uuid import uuid4
 
 from django.core.management import call_command
@@ -107,17 +107,18 @@ def setUp(self):
 
         reference = str(uuid4())
 
-        data = {
+        self.data = {
             'success': 'true',
             'eventCode': 'AUTHORISATION',
             'merchantReference': reference,
             'merchantAccountCode': settings.ADYEN_MERCHANT_ACCOUNT,
         }
 
-        self.notification1 = NotificationFactory.create(
-            notification=json.dumps(data),
-            is_processed=False
-        )
+        with freeze_time('2019-01-01 11:44'):
+            self.notification1 = NotificationFactory.create(
+                notification=json.dumps(self.data),
+                is_processed=False
+            )
         self.order1 = OrderFactory.create(
             status=Status.Pending,
             reference=reference
@@ -152,6 +153,57 @@ def test_process_notifications(self):
         self.assertTrue(self.notification1.is_processed)
         self.assertTrue(self.notification1.processed_at, datetime(2019, 1, 1, 12, 0))
 
+    @freeze_time('2019-01-01 12:00')
+    def test_process_notifications_is_error(self):
+        self.assertFalse(self.order1.paid)
+
+        self.data.update(eventCode='ERROR')
+        self.notification1.notification = json.dumps(self.data)
+        self.notification1.save()
+
+        call_command('adyen_maintenance')
+
+        self.order1.refresh_from_db()
+        self.assertFalse(self.order1.paid)
+
+        self.notification1.refresh_from_db()
+        self.assertTrue(self.notification1.is_processed)
+        self.assertTrue(self.notification1.processed_at, datetime(2019, 1, 1, 12, 0))
+
+    @freeze_time('2019-01-01 12:00')
+    def test_process_notifications_is_cancelled(self):
+        self.assertFalse(self.order1.paid)
+
+        self.data.update(eventCode='CANCEL')
+        self.notification1.notification = json.dumps(self.data)
+        self.notification1.save()
+
+        call_command('adyen_maintenance')
+
+        self.order1.refresh_from_db()
+        self.assertFalse(self.order1.paid)
+
+        self.notification1.refresh_from_db()
+        self.assertTrue(self.notification1.is_processed)
+        self.assertTrue(self.notification1.processed_at, datetime(2019, 1, 1, 12, 0))
+
+    @freeze_time('2019-01-01 12:00')
+    def test_process_notifications_is_refused(self):
+        self.assertFalse(self.order1.paid)
+
+        self.data.update(eventCode='REFUSED')
+        self.notification1.notification = json.dumps(self.data)
+        self.notification1.save()
+
+        call_command('adyen_maintenance')
+
+        self.order1.refresh_from_db()
+        self.assertFalse(self.order1.paid)
+
+        self.notification1.refresh_from_db()
+        self.assertTrue(self.notification1.is_processed)
+        self.assertTrue(self.notification1.processed_at, datetime(2019, 1, 1, 12, 0))
+
 
 class CleanupPending(TestCase):
     def test_cleanup(self):
@@ -168,15 +220,30 @@ def test_cleanup(self):
         with freeze_time('2019-01-3 12:00'):
             self.order4 = OrderFactory.create(status=Status.Authorised)
 
+        data = {
+            'success': 'true',
+            'eventCode': 'AUTHORISATION',
+            'merchantReference': 'unknown',
+            'merchantAccountCode': settings.ADYEN_MERCHANT_ACCOUNT,
+        }
+
+        with freeze_time('2019-01-01 11:44'):
+            self.notification1 = NotificationFactory.create(
+                notification=json.dumps(data),
+                is_processed=False
+            )
+
         with freeze_time('2019-01-10 12:00'):
             call_command('adyen_maintenance')
 
         self.order1.refresh_from_db()
         self.order2.refresh_from_db()
         self.order3.refresh_from_db()
         self.order4.refresh_from_db()
+        self.notification1.refresh_from_db()
 
         self.assertEqual(self.order1.status, Status.Error)
         self.assertEqual(self.order2.status, Status.Pending)
         self.assertEqual(self.order3.status, Status.Error)
         self.assertEqual(self.order4.status, Status.Authorised)
+        self.assertTrue(self.notification1.is_processed)