Skip to content

Commit 002722e

Browse files
SilviaAmAmsvenvandescheur
authored andcommitted
✅ [#296] Test resync behaviour
1 parent 221ee71 commit 002722e

File tree

3 files changed

+43
-5
lines changed

3 files changed

+43
-5
lines changed

backend/src/openarchiefbeheer/destruction/tests/test_tasks.py

+2
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,8 @@ def test_process_list(self):
228228
self.assertEqual(destruction_list.status, ListStatus.deleted)
229229
self.assertEqual(item1.processing_status, InternalStatus.succeeded)
230230
self.assertEqual(item2.processing_status, InternalStatus.succeeded)
231+
self.assertEqual(item1._zaak_url, "")
232+
self.assertEqual(item2._zaak_url, "")
231233

232234
self.assertFalse(
233235
Zaak.objects.filter(

backend/src/openarchiefbeheer/destruction/tests/test_utils.py

+38-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,15 @@
11
from django.test import TestCase
22

33
from openarchiefbeheer.accounts.tests.factories import UserFactory
4+
from openarchiefbeheer.zaken.tests.factories import ZaakFactory
45

56
from ..constants import ListRole
6-
from ..utils import process_new_assignees
7-
from .factories import DestructionListAssigneeFactory, DestructionListFactory
7+
from ..utils import process_new_assignees, resync_items_and_zaken
8+
from .factories import (
9+
DestructionListAssigneeFactory,
10+
DestructionListFactory,
11+
DestructionListItemFactory,
12+
)
813

914

1015
class UtilsTest(TestCase):
@@ -29,3 +34,34 @@ def test_process_assignees(self):
2934
self.assertEqual(2, new_assignees.count())
3035
self.assertEqual(users[0].pk, new_assignees[0].user.pk)
3136
self.assertEqual(users[1].pk, new_assignees[1].user.pk)
37+
38+
def test_resync_zaken(self):
39+
ZaakFactory.create(url="http://zaken.nl/1")
40+
ZaakFactory.create(url="http://zaken.nl/2")
41+
item1 = DestructionListItemFactory.create(_zaak_url="http://zaken.nl/1")
42+
item2 = DestructionListItemFactory.create(_zaak_url="http://zaken.nl/2")
43+
44+
resync_items_and_zaken()
45+
46+
item1.refresh_from_db()
47+
item2.refresh_from_db()
48+
49+
self.assertIsNotNone(item1.zaak)
50+
self.assertEqual(item1.zaak.url, "http://zaken.nl/1")
51+
self.assertIsNotNone(item2.zaak)
52+
self.assertEqual(item2.zaak.url, "http://zaken.nl/2")
53+
54+
def test_resync_zaken_missing(self):
55+
ZaakFactory.create(url="http://zaken.nl/1")
56+
ZaakFactory.create(url="http://zaken.nl/2")
57+
item1 = DestructionListItemFactory.create(_zaak_url="http://zaken.nl/1")
58+
item2 = DestructionListItemFactory.create(_zaak_url="http://zaken.nl/3")
59+
60+
resync_items_and_zaken()
61+
62+
item1.refresh_from_db()
63+
item2.refresh_from_db()
64+
65+
self.assertIsNotNone(item1.zaak)
66+
self.assertEqual(item1.zaak.url, "http://zaken.nl/1")
67+
self.assertIsNone(item2.zaak)

backend/src/openarchiefbeheer/zaken/tests/test_tasks.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from openarchiefbeheer.destruction.tests.factories import DestructionListItemFactory
1111

1212
from ..models import Zaak
13-
from ..tasks import retrieve_and_cache_zaken_from_openzaak
13+
from ..tasks import resync_zaken, retrieve_and_cache_zaken_from_openzaak
1414
from ..utils import get_procestype
1515
from .factories import ZaakFactory
1616

@@ -444,7 +444,7 @@ def test_expand_no_selectielijst_service(self, m):
444444
)
445445

446446
@tag("gh-296")
447-
def test_recaching_zaken_does_not_break_destruction_list(self, m):
447+
def test_resyncing_zaken_does_not_break_destruction_list(self, m):
448448
item = DestructionListItemFactory.create(
449449
with_zaak=True,
450450
zaak__url="http://zaken-api.nl/zaken/api/v1/zaken/75f4c682-1e16-45ea-8f78-99b4474986ac",
@@ -479,7 +479,7 @@ def test_recaching_zaken_does_not_break_destruction_list(self, m):
479479
},
480480
)
481481

482-
retrieve_and_cache_zaken_from_openzaak()
482+
resync_zaken()
483483

484484
item.refresh_from_db()
485485

0 commit comments

Comments
 (0)