🐛 [#303] Handle case where zaaktype identificatie is an empty string

SilviaAmAm · svenvandescheur · commit 20534dd5a8aa · 2024-08-26T11:42:40.000+02:00
diff --git a/backend/src/openarchiefbeheer/zaken/utils.py b/backend/src/openarchiefbeheer/zaken/utils.py
@@ -4,6 +4,7 @@
 from typing import TYPE_CHECKING, Callable, Generator, Literal
 
 from django.conf import settings
+from django.utils.translation import gettext as _
 
 from ape_pie import APIClient
 from djangorestframework_camel_case.parser import CamelCaseJSONParser
@@ -108,7 +109,7 @@ def retrieve_zaaktypen_choices() -> list[DropDownChoice]:
         .distinct()
     )
     zaaktypen_choices = [
-        {"label": key, "value": ",".join(value)}
+        {"label": key or _("(no identificatie)"), "value": ",".join(value)}
         for key, value in zaaktypen.items()
         if key in zaaktypes_to_include
     ]

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`	`from typing import TYPE_CHECKING, Callable, Generator, Literal`
`5`	`5`
`6`	`6`	`from django.conf import settings`
	`7`	`+from django.utils.translation import gettext as _`
`7`	`8`
`8`	`9`	`from ape_pie import APIClient`
`9`	`10`	`from djangorestframework_camel_case.parser import CamelCaseJSONParser`
`@@ -108,7 +109,7 @@ def retrieve_zaaktypen_choices() -> list[DropDownChoice]:`
`108`	`109`	`.distinct()`
`109`	`110`	`)`
`110`	`111`	`zaaktypen_choices = [`
`111`		`- {"label": key, "value": ",".join(value)}`
	`112`	`+ {"label": key or _("(no identificatie)"), "value": ",".join(value)}`
`112`	`113`	`for key, value in zaaktypen.items()`
`113`	`114`	`if key in zaaktypes_to_include`
`114`	`115`	`]`