✅ [#263] Test ordering of assignees in the destruction list endpoint

Author: SilviaAmAm

backend/src/openarchiefbeheer/destruction/tests/test_endpoints.py

@@ -779,6 +779,58 @@ def test_cannot_start_destruction_if_not_ready_to_delete(self):
         self.assertEqual(status.HTTP_403_FORBIDDEN, response.status_code)
         m_task.assert_not_called()
 
+    def test_reassign_swaps_reviewers(self):
+        record_manager = UserFactory.create(role__can_start_destruction=True)
+        destruction_list = DestructionListFactory.create(
+            name="A test list",
+            author=record_manager,
+        )
+        assignees = DestructionListAssigneeFactory.create_batch(
+            2, destruction_list=destruction_list, role=ListRole.reviewer
+        )
+
+        self.client.force_authenticate(user=record_manager)
+        response = self.client.get(
+            reverse(
+                "api:destructionlist-detail", kwargs={"uuid": destruction_list.uuid}
+            ),
+        )
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+
+        data = response.json()
+
+        self.assertEqual(data["assignees"][0]["user"]["pk"], assignees[0].user.pk)
+        self.assertEqual(data["assignees"][1]["user"]["pk"], assignees[1].user.pk)
+
+        # Swap the assignees
+        self.client.post(
+            reverse(
+                "api:destructionlist-reassign", kwargs={"uuid": destruction_list.uuid}
+            ),
+            data={
+                "assignees": [
+                    {"user": assignees[1].user.pk},
+                    {"user": assignees[0].user.pk},
+                ],
+                "comment": "Lorem ipsum...",
+                "role": ListRole.reviewer,
+            },
+            format="json",
+        )
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+
+        response = self.client.get(
+            reverse(
+                "api:destructionlist-detail", kwargs={"uuid": destruction_list.uuid}
+            ),
+        )
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+
+        data = response.json()
+
+        self.assertEqual(data["assignees"][0]["user"]["pk"], assignees[1].user.pk)
+        self.assertEqual(data["assignees"][1]["user"]["pk"], assignees[0].user.pk)
+
 
 class DestructionListItemsViewSetTest(APITestCase):
     def test_not_authenticated(self):

backend/src/openarchiefbeheer/destruction/tests/test_utils.py

@@ -7,8 +7,8 @@
 from .factories import DestructionListAssigneeFactory, DestructionListFactory
 
 
-class ProcessNewReviewersTest(TestCase):
-    def test_all_new_assignees_different(self):
+class UtilsTest(TestCase):
+    def test_process_assignees(self):
         destruction_list = DestructionListFactory.create()
         DestructionListAssigneeFactory.create_batch(
             3, role=ListRole.reviewer, destruction_list=destruction_list
@@ -29,29 +29,3 @@ def test_all_new_assignees_different(self):
         self.assertEqual(2, new_assignees.count())
         self.assertEqual(users[0].pk, new_assignees[0].user.pk)
         self.assertEqual(users[1].pk, new_assignees[1].user.pk)
-
-    def test_not_all_new_assignees_are_new(self):
-        destruction_list = DestructionListFactory.create()
-        old_assignees = DestructionListAssigneeFactory.create_batch(
-            2, role=ListRole.reviewer, destruction_list=destruction_list
-        )
-
-        users = UserFactory.create_batch(2, role__can_review_destruction=True)
-        new_assignee1 = {"user": users[0]}
-        new_assignee2 = {"user": users[1]}
-        new_assignee3 = {"user": old_assignees[0].user}
-
-        process_new_assignees(
-            destruction_list,
-            [new_assignee1, new_assignee2, new_assignee3],
-            ListRole.reviewer,
-        )
-
-        new_assignees = destruction_list.assignees.filter(
-            role=ListRole.reviewer
-        ).order_by("user__pk")
-
-        self.assertEqual(3, new_assignees.count())
-        self.assertEqual(old_assignees[0].user.pk, new_assignees[0].user.pk)
-        self.assertEqual(users[0].pk, new_assignees[1].user.pk)
-        self.assertEqual(users[1].pk, new_assignees[2].user.pk)