Skip to content

Commit 2fb0fa0

Browse files
🏷️ - fix: fix type issues with default values for variables
1 parent 1be54cd commit 2fb0fa0

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

backend/src/openarchiefbeheer/destruction/api/serializers.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -267,9 +267,9 @@ def update(
267267
) -> DestructionList:
268268
user = self.context["request"].user
269269
validated_data.pop("reviewer", None)
270-
add_data = validated_data.pop("add", None)
271-
remove_data = validated_data.pop("remove", None)
272-
items_data = validated_data.pop("items", None)
270+
add_data = validated_data.pop("add", [])
271+
remove_data = validated_data.pop("remove", [])
272+
items_data = validated_data.pop("items", [])
273273
instance.contains_sensitive_info = validated_data.pop(
274274
"contains_sensitive_info", instance.contains_sensitive_info
275275
)
@@ -278,15 +278,15 @@ def update(
278278

279279
instance.name = validated_data.pop("name", instance.name)
280280

281-
if items_data is not None or bulk_select:
281+
if items_data or bulk_select:
282282
instance.items.all().delete()
283283

284284
zaken = self._get_zaken(zaak_filters, items_data, bulk_select)
285285

286286
instance.add_items(zaken)
287287

288288
if add_data:
289-
zaken = self._get_zaken(zaak_filters, add_data or [], bulk_select)
289+
zaken = self._get_zaken(zaak_filters, add_data, bulk_select)
290290
self.instance.add_items(zaken)
291291

292292
if remove_data:

0 commit comments

Comments
 (0)