✅ [#227] Test reassigning assignees

Author: SilviaAmAm

backend/src/openarchiefbeheer/destruction/tests/test_assignement_logic.py

@@ -2,6 +2,7 @@
 
 from django.test import TestCase
 
+from openarchiefbeheer.accounts.tests.factories import UserFactory
 from openarchiefbeheer.config.models import ArchiveConfig
 from openarchiefbeheer.zaken.tests.factories import ZaakFactory
 
@@ -214,3 +215,58 @@ def test_archivist_accepts(self):
 
         self.assertEqual(destruction_list.status, ListStatus.ready_to_delete)
         self.assertEqual(destruction_list.assignee, record_manager.user)
+
+    def test_reassign_reviewers_ready_to_review(self):
+        reviewer_old = UserFactory.create(role__can_review_destruction=True)
+        destruction_list = DestructionListFactory.create(
+            status=ListStatus.ready_to_review, assignee=reviewer_old
+        )
+        assignees = DestructionListAssigneeFactory.create_batch(
+            2, role=ListRole.reviewer, destruction_list=destruction_list
+        )
+
+        destruction_list.reassign()
+
+        destruction_list.refresh_from_db()
+
+        self.assertEqual(destruction_list.status, ListStatus.ready_to_review)
+        self.assertEqual(destruction_list.assignee, assignees[0].user)
+
+    def test_reassign_reviewers_noop(self):
+        record_manager = UserFactory.create(role__can_start_destruction=True)
+        destruction_list = DestructionListFactory.create(
+            status=ListStatus.new, assignee=record_manager, author=record_manager
+        )
+        DestructionListAssigneeFactory.create_batch(
+            2, role=ListRole.reviewer, destruction_list=destruction_list
+        )
+
+        with self.subTest("New"):
+            destruction_list.reassign()
+
+            destruction_list.refresh_from_db()
+
+            self.assertEqual(destruction_list.status, ListStatus.new)
+            self.assertEqual(destruction_list.assignee, record_manager)
+
+        with self.subTest("Changes requested"):
+            destruction_list.status = ListStatus.changes_requested
+            destruction_list.save()
+
+            destruction_list.reassign()
+
+            destruction_list.refresh_from_db()
+
+            self.assertEqual(destruction_list.status, ListStatus.changes_requested)
+            self.assertEqual(destruction_list.assignee, record_manager)
+
+        with self.subTest("Internally reviewed"):
+            destruction_list.status = ListStatus.internally_reviewed
+            destruction_list.save()
+
+            destruction_list.reassign()
+
+            destruction_list.refresh_from_db()
+
+            self.assertEqual(destruction_list.status, ListStatus.internally_reviewed)
+            self.assertEqual(destruction_list.assignee, record_manager)

backend/src/openarchiefbeheer/destruction/tests/test_utils.py

@@ -0,0 +1,57 @@
+from django.test import TestCase
+
+from openarchiefbeheer.accounts.tests.factories import UserFactory
+
+from ..constants import ListRole
+from ..utils import process_new_assignees
+from .factories import DestructionListAssigneeFactory, DestructionListFactory
+
+
+class ProcessNewReviewersTest(TestCase):
+    def test_all_new_assignees_different(self):
+        destruction_list = DestructionListFactory.create()
+        DestructionListAssigneeFactory.create_batch(
+            3, role=ListRole.reviewer, destruction_list=destruction_list
+        )
+
+        users = UserFactory.create_batch(2, role__can_review_destruction=True)
+        new_assignee1 = {"user": users[0]}
+        new_assignee2 = {"user": users[1]}
+
+        process_new_assignees(
+            destruction_list, [new_assignee1, new_assignee2], ListRole.reviewer
+        )
+
+        new_assignees = destruction_list.assignees.filter(
+            role=ListRole.reviewer
+        ).order_by("user__pk")
+
+        self.assertEqual(2, new_assignees.count())
+        self.assertEqual(users[0].pk, new_assignees[0].user.pk)
+        self.assertEqual(users[1].pk, new_assignees[1].user.pk)
+
+    def test_not_all_new_assignees_are_new(self):
+        destruction_list = DestructionListFactory.create()
+        old_assignees = DestructionListAssigneeFactory.create_batch(
+            2, role=ListRole.reviewer, destruction_list=destruction_list
+        )
+
+        users = UserFactory.create_batch(2, role__can_review_destruction=True)
+        new_assignee1 = {"user": users[0]}
+        new_assignee2 = {"user": users[1]}
+        new_assignee3 = {"user": old_assignees[0].user}
+
+        process_new_assignees(
+            destruction_list,
+            [new_assignee1, new_assignee2, new_assignee3],
+            ListRole.reviewer,
+        )
+
+        new_assignees = destruction_list.assignees.filter(
+            role=ListRole.reviewer
+        ).order_by("user__pk")
+
+        self.assertEqual(3, new_assignees.count())
+        self.assertEqual(old_assignees[0].user.pk, new_assignees[0].user.pk)
+        self.assertEqual(users[0].pk, new_assignees[1].user.pk)
+        self.assertEqual(users[1].pk, new_assignees[2].user.pk)