Skip to content

Commit 856cecc

Browse files
committed
💚 [#234] Fix E2E tests
1 parent 7a201bc commit 856cecc

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

backend/src/openarchiefbeheer/utils/tests/gherkin.py

+11-2
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,9 @@ async def handle(route):
222222
await page.route("**/*/api/v1/_selectielijstklasse-choices/?zaak=*", handle)
223223

224224
async def zaken_are_indexed(self, amount, **kwargs):
225-
return await self._get_or_create_batch(ZaakFactory, amount, **kwargs)
225+
return await self._get_or_create_batch(
226+
ZaakFactory, amount, with_expand=True, **kwargs
227+
)
226228

227229
@sync_to_async
228230
def _orm_get(self, model, **kwargs):
@@ -252,7 +254,14 @@ async def _get_or_create(self, factory, **kwargs):
252254
return await self._factory_create(factory, **kwargs)
253255

254256
async def _get_or_create_batch(self, factory, amount, **kwargs):
255-
queryset = await self._orm_filter(factory._meta.model, **kwargs)
257+
# Remove any traits of the factory
258+
orm_params = {
259+
key: value
260+
for key, value in kwargs.items()
261+
if key not in factory._meta.parameters
262+
}
263+
264+
queryset = await self._orm_filter(factory._meta.model, **orm_params)
256265
if queryset:
257266
return queryset
258267
return await self._factory_create_batch(factory, amount, **kwargs)

backend/src/openarchiefbeheer/zaken/tests/factories.py

+1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ class Params:
3131
"url": "https://selectielijst.nl/api/v1/procestypen/7ff2b005-4d84-47fe-983a-732bfa958ff5",
3232
},
3333
"omschrijving": "Aangifte behandelen",
34+
"identificatie": "ZAAKTYPE-01",
3435
},
3536
"resultaat": {
3637
"resultaattype": "http://catalogue-api.nl/catalogi/api/v1/resultaattypen/111-111-111",

0 commit comments

Comments
 (0)