✅ [#93] Test retrying deletion

Author: SilviaAmAm

backend/src/openarchiefbeheer/destruction/models.py

@@ -274,9 +274,7 @@ def process_deletion(self) -> None:
             store = ResultStore(store=self)
             store.clear_traceback()
 
-            delete_zaak_and_related_objects(
-                zaak=zaak, result_store=store
-            )
+            delete_zaak_and_related_objects(zaak=zaak, result_store=store)
 
             zaak.delete()
 

backend/src/openarchiefbeheer/destruction/tests/test_tasks.py

@@ -302,3 +302,36 @@ def test_item_skipped_if_already_succeeded(self, logs):
             ),
             logs[0],
         )
+
+    @override_settings(CELERY_TASK_ALWAYS_EAGER=True)
+    def test_processing_list_with_failed_item(self):
+        destruction_list = DestructionListFactory.create(
+            status=ListStatus.ready_to_delete, processing_status=InternalStatus.failed
+        )
+        zaak = ZaakFactory.create()
+        DestructionListItemFactory.create(
+            zaak=zaak.url,
+            destruction_list=destruction_list,
+            processing_status=InternalStatus.failed,
+            internal_results={"traceback": "Some traceback"},
+        )
+
+        with (
+            patch(
+                "openarchiefbeheer.destruction.models.delete_zaak_and_related_objects",
+            ),
+        ):
+            delete_destruction_list(destruction_list)
+
+        destruction_list.refresh_from_db()
+
+        self.assertEqual(destruction_list.processing_status, InternalStatus.succeeded)
+        self.assertEqual(destruction_list.status, ListStatus.deleted)
+
+        item = destruction_list.items.first()
+
+        self.assertEqual(item.processing_status, InternalStatus.succeeded)
+        self.assertEqual(
+            item.internal_results,
+            {"deleted_resources": {}, "resources_to_delete": {}, "traceback": ""},
+        )

backend/src/openarchiefbeheer/zaken/utils.py

@@ -152,6 +152,7 @@ def delete_object_and_store_result(
         response.raise_for_status()
     except HTTPError as exc:
         if not http_error_handler:
+            store.add_traceback(traceback.format_exc())
             raise exc
         return http_error_handler(exc)
     except Exception as exc: