Skip to content

Commit ad25495

Browse files
committed
✨ [#262] Paginate destruction list items
1 parent f3660d9 commit ad25495

File tree

4 files changed

+11
-8
lines changed

4 files changed

+11
-8
lines changed

backend/src/openarchiefbeheer/destruction/api/viewsets.py

+2
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
from rest_framework.response import Response
1212

1313
from openarchiefbeheer.logging import logevent
14+
from openarchiefbeheer.utils.paginators import PageNumberPagination
1415

1516
from ..constants import InternalStatus, ListRole
1617
from ..models import (
@@ -299,6 +300,7 @@ class DestructionListItemsViewSet(
299300
queryset = DestructionListItem.objects.all()
300301
filter_backends = (DjangoFilterBackend,)
301302
filterset_class = DestructionListItemFilterset
303+
pagination_class = PageNumberPagination
302304

303305

304306
@extend_schema_view(

backend/src/openarchiefbeheer/destruction/tests/test_endpoints.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -819,7 +819,7 @@ def test_retrieve_destruction_list_items(self):
819819

820820
self.assertEqual(response.status_code, status.HTTP_200_OK)
821821

822-
data = sorted(response.json(), key=lambda item: item["zaak"])
822+
data = sorted(response.json()["results"], key=lambda item: item["zaak"])
823823

824824
self.assertEqual(
825825
data[0]["zaakData"]["omschrijving"],
@@ -868,7 +868,7 @@ def test_filter_items_on_destruction_list(self):
868868

869869
data = response.json()
870870

871-
self.assertEqual(len(data), 2)
871+
self.assertEqual(data["count"], 2)
872872

873873

874874
class DestructionListReviewViewSetTest(APITestCase):
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
from rest_framework.pagination import PageNumberPagination as _PageNumberPagination
2+
3+
4+
class PageNumberPagination(_PageNumberPagination):
5+
page_size_query_param = "page_size"
6+
page_size = 100

backend/src/openarchiefbeheer/zaken/api/viewsets.py

+1-6
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,19 @@
44
from drf_spectacular.utils import extend_schema, extend_schema_view
55
from rest_framework import mixins, viewsets
66
from rest_framework.filters import OrderingFilter
7-
from rest_framework.pagination import PageNumberPagination as _PageNumberPagination
87
from rest_framework.permissions import IsAuthenticated
98

109
from openarchiefbeheer.destruction.api.permissions import (
1110
CanReviewPermission,
1211
CanStartDestructionPermission,
1312
)
13+
from openarchiefbeheer.utils.paginators import PageNumberPagination
1414

1515
from ..models import Zaak
1616
from .filtersets import ZaakFilter
1717
from .serializers import ZaakSerializer
1818

1919

20-
class PageNumberPagination(_PageNumberPagination):
21-
page_size_query_param = "page_size"
22-
page_size = 100
23-
24-
2520
@extend_schema_view(
2621
list=extend_schema(
2722
summary=_("List zaken"),

0 commit comments

Comments
 (0)