Skip to content

Commit c5ae7d1

Browse files
committed
✅ [#386] Fix tests
1 parent fd0d080 commit c5ae7d1

File tree

2 files changed

+49
-32
lines changed

2 files changed

+49
-32
lines changed

backend/src/openarchiefbeheer/destruction/tests/e2e/features/test_feature_list_process_review.py

+9
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
# fmt: off
2+
from unittest.mock import patch
3+
24
from django.test import tag
35

46
from asgiref.sync import sync_to_async
@@ -24,6 +26,13 @@
2426
@tag("e2e")
2527
class FeatureProcessReviewTests(GherkinLikeTestCase):
2628
async def test_scenario_record_manager_process_review(self):
29+
patcher = patch(
30+
"openarchiefbeheer.destruction.api.serializers.retrieve_selectielijstklasse_resultaat",
31+
return_value={"waardering": "vernietigen"}
32+
)
33+
patcher.start()
34+
self.addCleanup(patcher.stop)
35+
2736
async with browser_page() as page:
2837
await self.given.selectielijstklasse_choices_are_available(page)
2938
record_manager = await self.given.record_manager_exists()

backend/src/openarchiefbeheer/destruction/tests/endpoints/test_reviewresponse.py

+40-32
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
from unittest.mock import patch
2+
13
from django.utils.translation import gettext_lazy as _
24

35
import freezegun
@@ -61,46 +63,52 @@ def test_create_review_response(self):
6163
items_reviews = DestructionListItemReviewFactory.create_batch(
6264
3,
6365
destruction_list_item__destruction_list=review.destruction_list,
66+
destruction_list_item__with_zaak=True,
67+
destruction_list_item__zaak__selectielijstklasse="http://some-url.nl",
6468
review=review,
6569
)
6670

6771
endpoint = reverse("api:review-responses-list")
6872
self.client.force_authenticate(user=record_manager)
6973

70-
response = self.client.post(
71-
endpoint,
72-
data={
73-
"review": review.pk,
74-
"comment": "A comment about the review.",
75-
"itemsResponses": [
76-
{
77-
"reviewItem": items_reviews[0].pk,
78-
"actionItem": DestructionListItemAction.keep,
79-
"comment": "This zaak needs to stay in the list.",
80-
},
81-
{
82-
"reviewItem": items_reviews[1].pk,
83-
"actionItem": DestructionListItemAction.remove,
84-
"actionZaak": {
85-
"action_type": ZaakActionType.selectielijstklasse_and_bewaartermijn,
86-
"selectielijstklasse": "http://some-url.nl",
87-
"archiefactiedatum": "2030-01-01",
74+
with patch(
75+
"openarchiefbeheer.destruction.api.serializers.retrieve_selectielijstklasse_resultaat",
76+
return_value={"waardering": "vernietigen"},
77+
):
78+
response = self.client.post(
79+
endpoint,
80+
data={
81+
"review": review.pk,
82+
"comment": "A comment about the review.",
83+
"itemsResponses": [
84+
{
85+
"reviewItem": items_reviews[0].pk,
86+
"actionItem": DestructionListItemAction.keep,
87+
"comment": "This zaak needs to stay in the list.",
8888
},
89-
"comment": "Changed the selectielijstklasse and removed from the list.",
90-
},
91-
{
92-
"reviewItem": items_reviews[2].pk,
93-
"actionItem": DestructionListItemAction.remove,
94-
"actionZaak": {
95-
"action_type": ZaakActionType.bewaartermijn,
96-
"archiefactiedatum": "2030-01-01",
89+
{
90+
"reviewItem": items_reviews[1].pk,
91+
"actionItem": DestructionListItemAction.remove,
92+
"actionZaakType": ZaakActionType.selectielijstklasse_and_bewaartermijn,
93+
"actionZaak": {
94+
"selectielijstklasse": "http://some-url.nl",
95+
"archiefactiedatum": "2030-01-01",
96+
},
97+
"comment": "Changed the selectielijstklasse and removed from the list.",
9798
},
98-
"comment": "Changed the archiefactiedatum and removed from the list.",
99-
},
100-
],
101-
},
102-
format="json",
103-
)
99+
{
100+
"reviewItem": items_reviews[2].pk,
101+
"actionItem": DestructionListItemAction.remove,
102+
"actionZaakType": ZaakActionType.bewaartermijn,
103+
"actionZaak": {
104+
"archiefactiedatum": "2030-01-01",
105+
},
106+
"comment": "Changed the archiefactiedatum and removed from the list.",
107+
},
108+
],
109+
},
110+
format="json",
111+
)
104112

105113
self.assertEqual(response.status_code, status.HTTP_201_CREATED)
106114
self.assertEqual(ReviewResponse.objects.filter(review=review).count(), 1)

0 commit comments

Comments
 (0)