Skip to content

Commit e9a4ed0

Browse files
committed
🚚 [#738] Rename REACT_APP_ env vars to OAB_
1 parent 1837682 commit e9a4ed0

File tree

6 files changed

+14
-14
lines changed

6 files changed

+14
-14
lines changed

.github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
npm run lint
3939
CI=false npm run build
4040
env:
41-
REACT_APP_API_URL: "http://localhost:8000"
41+
OAB_API_URL: "http://localhost:8000"
4242

4343
- uses: actions/upload-artifact@v4
4444
with:

backend/docs/developers/e2e-tests.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Then, you need to build the frontend. You can do this in the folder ``frontend/`
2323
npm ci
2424
npm run build
2525
26-
Note that the value of the ``REACT_APP_API_URL`` environment variable is important. The live Django server started
26+
Note that the value of the ``OAB_API_URL`` environment variable is important. The live Django server started
2727
by the ``StaticLiveServerTestCase`` needs to have the same url. The class ``PlaywrightTestCase`` in the file
2828
``backend/src/openarchiefbeheer/utils/tests/e2e.py`` is a wrapper for ``StaticLiveServerTestCase`` and specifies
2929
on which port the live server will run during the tests.

docker-compose.dev.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ services:
5050
- CELERY_BROKER_URL=redis://redis:6379/0
5151
- CELERY_RESULT_BACKEND=redis://redis:6379/0
5252
- CELERY_LOGLEVEL=DEBUG
53-
- REACT_APP_API_URL=http://localhost:8000
54-
- REACT_APP_API_PATH=/api/v1
55-
- REACT_APP_ZAAK_URL_TEMPLATE=https://www.example.com/zaken/{identificatie}
53+
- OAB_API_URL=http://localhost:8000
54+
- OAB_API_PATH=/api/v1
55+
- OAB_ZAAK_URL_TEMPLATE=https://www.example.com/zaken/{identificatie}
5656
- REQUESTS_READ_TIMEOUT=5000
5757
- DISABLE_2FA=yes
5858
ports:

docker-compose.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ services:
4747
- CELERY_BROKER_URL=redis://redis:6379/0
4848
- CELERY_RESULT_BACKEND=redis://redis:6379/0
4949
- CELERY_LOGLEVEL=DEBUG
50-
- REACT_APP_API_URL=http://localhost:8000
51-
- REACT_APP_API_PATH=/api/v1
52-
- REACT_APP_ZAAK_URL_TEMPLATE=https://www.example.com/zaken/{identificatie}
50+
- OAB_API_URL=http://localhost:8000
51+
- OAB_API_PATH=/api/v1
52+
- OAB_ZAAK_URL_TEMPLATE=https://www.example.com/zaken/{identificatie}
5353
- REQUESTS_READ_TIMEOUT=5000
5454
ports:
5555
- 8000:8000

frontend/.env.production.template

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
REACT_APP_API_URL=REACT_APP_API_URL_PLACEHOLDER
2-
REACT_APP_API_PATH=REACT_APP_API_PATH_PLACEHOLDER
3-
REACT_APP_ZAAK_URL_TEMPLATE=REACT_APP_ZAAK_URL_TEMPLATE_PLACEHOLDER
1+
OAB_API_URL=OAB_API_URL_PLACEHOLDER
2+
OAB_API_PATH=OAB_API_PATH_PLACEHOLDER
3+
OAB_ZAAK_URL_TEMPLATE=OAB_ZAAK_URL_TEMPLATE_PLACEHOLDER

frontend/scripts/replace-envvars.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ set -eux -o pipefail
44

55
for file in /app/static/assets/*.js;
66
do
7-
sed -i 's|REACT_APP_API_URL_PLACEHOLDER|'${REACT_APP_API_URL}'|g' $file
8-
sed -i 's|REACT_APP_API_PATH_PLACEHOLDER|'${REACT_APP_API_PATH}'|g' $file
9-
sed -i 's|REACT_APP_ZAAK_URL_TEMPLATE_PLACEHOLDER|'${REACT_APP_ZAAK_URL_TEMPLATE}'|g' $file
7+
sed -i 's|OAB_API_URL_PLACEHOLDER|'${OAB_API_URL}'|g' $file
8+
sed -i 's|OAB_API_PATH_PLACEHOLDER|'${OAB_API_PATH}'|g' $file
9+
sed -i 's|OAB_ZAAK_URL_TEMPLATE_PLACEHOLDER|'${OAB_ZAAK_URL_TEMPLATE}'|g' $file
1010
done

0 commit comments

Comments
 (0)